diff options
| author |  Michael J Gruber <git@drmicha.warpmail.net> | 2010-07-12 12:32:18 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2010-07-12 07:52:52 -0700 |
| commit | 47e67d479b305bbec996b2422e2776fb7c39be27 (patch) | |
| tree | f685e7358662024249640beaeec91a9c6508d2c7 | |
| parent | Merge branch 'maint' (diff) | |
| download | tgif-47e67d479b305bbec996b2422e2776fb7c39be27.tar.xz | |
test-lib: simplify GIT_SKIP_TESTS loop
04ece59 (GIT_SKIP_TESTS: allow users to omit tests that are known to break, 2006-12-28)
introduced GIT_SKIP_TESTS, and since then we have had two nested loops
iterating over GIT_SKIP_TESTS with the same loop variable.
Reduce this to one loop.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | t/test-lib.sh | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/t/test-lib.sh b/t/test-lib.sh index ac496aa479..bc0656457b 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -385,6 +385,7 @@ test_skip () { case $this_test.$test_count in $skp) to_skip=t + break esac done if test -z "$to_skip" && test -n "$prereq" && @@ -829,16 +830,8 @@ this_test=${0##*/} this_test=${this_test%%-*} for skp in $GIT_SKIP_TESTS do - to_skip= - for skp in $GIT_SKIP_TESTS - do - case "$this_test" in - $skp) - to_skip=t - esac - done - case "$to_skip" in - t) + case "$this_test" in + $skp) say_color skip >&3 "skipping test $this_test altogether" say_color skip "skip all tests in $this_test" test_done |