diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2018-02-15 15:18:10 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-02-15 15:18:10 -0800 |
| commit | 468dc22e0085db29994b4296ca0127f27a686fa0 (patch) | |
| tree | bbc3dde066a79001dd1524745559f88e09a17995 | |
| parent | Merge branch 'ab/perf-grep-threads' into maint (diff) | |
| parent | describe: prepend "tags/" when describing tags with embedded name (diff) | |
| download | tgif-468dc22e0085db29994b4296ca0127f27a686fa0.tar.xz | |
Merge branch 'dk/describe-all-output-fix' into maint
An old regression in "git describe --all $annotated_tag^0" has been
fixed.
* dk/describe-all-output-fix:
describe: prepend "tags/" when describing tags with embedded name
| -rw-r--r-- | builtin/describe.c | 7 | ||||
| -rwxr-xr-x | t/t6120-describe.sh | 6 |
2 files changed, 10 insertions, 3 deletions
diff --git a/builtin/describe.c b/builtin/describe.c index 3b0b204b1e..6fe1c51281 100644 --- a/builtin/describe.c +++ b/builtin/describe.c @@ -274,10 +274,13 @@ static void append_name(struct commit_name *n, struct strbuf *dst) n->name_checked = 1; } - if (n->tag) + if (n->tag) { + if (all) + strbuf_addstr(dst, "tags/"); strbuf_addstr(dst, n->tag->tag); - else + } else { strbuf_addstr(dst, n->path); + } } static void append_suffix(int depth, const struct object_id *oid, struct strbuf *dst) diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index 3e3fb462a0..a5d9015024 100755 --- a/t/t6120-describe.sh +++ b/t/t6120-describe.sh @@ -122,7 +122,7 @@ test_expect_success 'describe --contains defaults to HEAD without commit-ish' ' ' : >err.expect -check_describe A --all A^0 +check_describe tags/A --all A^0 test_expect_success 'no warning was displayed for A' ' test_cmp err.expect err.actual ' @@ -374,4 +374,8 @@ test_expect_success ULIMIT_STACK_SIZE 'describe works in a deep repo' ' test_cmp expect actual ' +check_describe tags/A --all A +check_describe tags/c --all c +check_describe heads/branch_A --all --match='branch_*' branch_A + test_done |