diff options
| author |  Johannes Schindelin <Johannes.Schindelin@gmx.de> | 2008-08-08 04:29:35 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2008-08-07 21:25:27 -0700 |
| commit | 468386a956c09ff59dd2b8fd681e162b2e167392 (patch) | |
| tree | d497047fbdb7893c5693574792ea2c242ed7e367 | |
| parent | GIT 1.6.0-rc2 (diff) | |
| download | tgif-468386a956c09ff59dd2b8fd681e162b2e167392.tar.xz | |
clone --mirror: avoid storing repeated tags
With --mirror, clone asks for refs/* already, so it does not need to
ask for ref/tags/*, too.
Noticed by Cesar Eduardo Barros.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin-clone.c | 3 | ||||
| -rwxr-xr-x | t/t5601-clone.sh | 12 |
2 files changed, 14 insertions, 1 deletions
diff --git a/builtin-clone.c b/builtin-clone.c index 8612d59dd2..c0e3086437 100644 --- a/builtin-clone.c +++ b/builtin-clone.c @@ -330,7 +330,8 @@ static struct ref *write_remote_refs(const struct ref *refs, struct ref *r; get_fetch_map(refs, refspec, &tail, 0); - get_fetch_map(refs, tag_refspec, &tail, 0); + if (!option_mirror) + get_fetch_map(refs, tag_refspec, &tail, 0); for (r = local_refs; r; r = r->next) add_extra_ref(r->peer_ref->name, r->old_sha1, 0); diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index a13b6f9d3d..59c65fef28 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -95,4 +95,16 @@ test_expect_success 'clone --bare names the local repository <name>.git' ' ' +test_expect_success 'clone --mirror does not repeat tags' ' + + (cd src && + git tag some-tag HEAD) && + git clone --mirror src mirror2 && + (cd mirror2 && + git show-ref 2> clone.err > clone.out) && + test_must_fail grep Duplicate mirror2/clone.err && + grep some-tag mirror2/clone.out + +' + test_done |