diff options
| author |  Jeff King <peff@peff.net> | 2012-05-21 19:10:08 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2012-05-22 09:07:53 -0700 |
| commit | 43ae9f47ab8a7762d914e91d6f57b79126986640 (patch) | |
| tree | 7a56a359641d9c083a7cf4cc138571a2fb8444a6 | |
| parent | ident: trim trailing newline from /etc/mailname (diff) | |
| download | tgif-43ae9f47ab8a7762d914e91d6f57b79126986640.tar.xz | |
format-patch: use default email for generating message ids
We try to generate a sane message id for cover letters and
threading by appending some changing bits to the front of
the user's email address. The current code parses the email
out of the results of git_committer_info, but we can do this
much more easily by just calling ident_default_email
ourselves.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/log.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/builtin/log.c b/builtin/log.c index 690caa7830..656bddfb03 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -737,15 +737,9 @@ static void get_patch_ids(struct rev_info *rev, struct patch_ids *ids, const cha static void gen_message_id(struct rev_info *info, char *base) { - const char *committer = git_committer_info(IDENT_WARN_ON_NO_NAME); - const char *email_start = strrchr(committer, '<'); - const char *email_end = strrchr(committer, '>'); struct strbuf buf = STRBUF_INIT; - if (!email_start || !email_end || email_start > email_end - 1) - die(_("Could not extract email from committer identity.")); - strbuf_addf(&buf, "%s.%lu.git.%.*s", base, - (unsigned long) time(NULL), - (int)(email_end - email_start - 1), email_start + 1); + strbuf_addf(&buf, "%s.%lu.git.%s", base, + (unsigned long) time(NULL), ident_default_email()); info->message_id = strbuf_detach(&buf, NULL); } |