diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2017-09-10 17:02:53 +0900 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-09-10 17:02:53 +0900 |
| commit | 438776e3d48779417a7f9cfc6eaf0bb58d7d6cca (patch) | |
| tree | eb35567c3b3b5a096a63210d3df3c11ee18201f3 | |
| parent | Merge branch 'rs/fsck-obj-leakfix' into maint (diff) | |
| parent | sha1_file: release delta_stack on error in unpack_entry() (diff) | |
| download | tgif-438776e3d48779417a7f9cfc6eaf0bb58d7d6cca.tar.xz | |
Merge branch 'rs/unpack-entry-leakfix' into maint
Memory leak in an error codepath has been plugged.
* rs/unpack-entry-leakfix:
sha1_file: release delta_stack on error in unpack_entry()
| -rw-r--r-- | sha1_file.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sha1_file.c b/sha1_file.c index b60ae15f70..b7bb38b445 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -2542,8 +2542,8 @@ void *unpack_entry(struct packed_git *p, off_t obj_offset, error("bad packed object CRC for %s", sha1_to_hex(sha1)); mark_bad_packed_object(p, sha1); - unuse_pack(&w_curs); - return NULL; + data = NULL; + goto out; } } @@ -2681,6 +2681,7 @@ void *unpack_entry(struct packed_git *p, off_t obj_offset, if (final_size) *final_size = size; +out: unuse_pack(&w_curs); if (delta_stack != small_delta_stack) |