diff options
| author |  Robert Fitzsimons <robfitz@273k.net> | 2006-12-22 19:38:14 +0000 |
|---|---|---|
| committer |  Junio C Hamano <junkio@cox.net> | 2006-12-22 23:18:16 -0800 |
| commit | 3fcf06be5d02de15992d11482cfae82dc058261b (patch) | |
| tree | 1fc64299844aac5019a27e21c5104b2e4648509d | |
| parent | gitweb: optimize git_get_last_activity. (diff) | |
| download | tgif-3fcf06be5d02de15992d11482cfae82dc058261b.tar.xz | |
gitweb: optimize git_shortlog_body.
Don't call gitweb_have_snapshot from within the loop.
Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| -rwxr-xr-x | gitweb/gitweb.perl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 01e3a8adaa..d2ddac8bf3 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -2636,6 +2636,8 @@ sub git_shortlog_body { # uses global variable $project my ($revlist, $from, $to, $refs, $extra) = @_; + my $have_snapshot = gitweb_have_snapshot(); + $from = 0 unless defined $from; $to = $#{$revlist} if (!defined $to || $#{$revlist} < $to); @@ -2663,7 +2665,7 @@ sub git_shortlog_body { $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") . " | " . $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " . $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree"); - if (gitweb_have_snapshot()) { + if ($have_snapshot) { print " | " . $cgi->a({-href => href(action=>"snapshot", hash=>$commit)}, "snapshot"); } print "</td>\n" . |