diff options
| author |  Shawn O. Pearce <spearce@spearce.org> | 2009-02-10 13:36:12 -0800 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2009-02-10 15:30:59 -0800 |
| commit | 3d20c636af05c44a6ff4df9309c2bca108ee149b (patch) | |
| tree | 97e2732bcb3039de582f9118077a43a1dc6e0472 | |
| parent | Fixed broken git help -w when installing from RPM (diff) | |
| download | tgif-3d20c636af05c44a6ff4df9309c2bca108ee149b.tar.xz | |
Clear the delta base cache during fast-import checkpoint
Otherwise we may reuse the same memory address for a totally
different "struct packed_git", and a previously cached object from
the prior occupant might be returned when trying to unpack an object
from the new pack.
Found-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | cache.h | 1 | ||||
| -rw-r--r-- | fast-import.c | 1 | ||||
| -rw-r--r-- | sha1_file.c | 7 |
3 files changed, 9 insertions, 0 deletions
@@ -739,6 +739,7 @@ extern unsigned char* use_pack(struct packed_git *, struct pack_window **, off_t extern void close_pack_windows(struct packed_git *); extern void unuse_pack(struct pack_window **); extern void free_pack_by_name(const char *); +extern void clear_delta_base_cache(void); extern struct packed_git *add_packed_git(const char *, int, int); extern const unsigned char *nth_packed_object_sha1(struct packed_git *, uint32_t); extern off_t nth_packed_object_offset(const struct packed_git *, uint32_t); diff --git a/fast-import.c b/fast-import.c index 6d5ee6f463..5bc9ce2cc9 100644 --- a/fast-import.c +++ b/fast-import.c @@ -943,6 +943,7 @@ static void end_packfile(void) { struct packed_git *old_p = pack_data, *new_p; + clear_delta_base_cache(); if (object_count) { char *idx_name; int i; diff --git a/sha1_file.c b/sha1_file.c index 0cfea9edc1..cbcae24d28 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -1630,6 +1630,13 @@ static inline void release_delta_base_cache(struct delta_base_cache_entry *ent) } } +void clear_delta_base_cache(void) +{ + unsigned long p; + for (p = 0; p < MAX_DELTA_CACHE; p++) + release_delta_base_cache(&delta_base_cache[p]); +} + static void add_delta_base_cache(struct packed_git *p, off_t base_offset, void *base, unsigned long base_size, enum object_type type) { |