diff options
| author |  Elia Pinto <gitter.spiros@gmail.com> | 2016-01-08 12:06:22 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2016-01-08 12:54:06 -0800 |
| commit | 33c85913dffb9a2328a97f0ac5c15609f9a64e28 (patch) | |
| tree | 5bc9396d891baeec21db8129a5676fb8bdae838a | |
| parent | t/t7408-submodule-reference.sh: use the $( ... ) construct for command substi... (diff) | |
| download | tgif-33c85913dffb9a2328a97f0ac5c15609f9a64e28.tar.xz | |
t/t7504-commit-msg-hook.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t7504-commit-msg-hook.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t7504-commit-msg-hook.sh b/t/t7504-commit-msg-hook.sh index 1f53ea8090..8728db61d3 100755 --- a/t/t7504-commit-msg-hook.sh +++ b/t/t7504-commit-msg-hook.sh @@ -179,7 +179,7 @@ EOF chmod +x "$HOOK" commit_msg_is () { - test "`git log --pretty=format:%s%b -1`" = "$1" + test "$(git log --pretty=format:%s%b -1)" = "$1" } test_expect_success 'hook edits commit message' ' |