diff options
author | Jiang Xin <worldhello.net@gmail.com> | 2012-07-25 22:53:12 +0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2012-07-26 22:34:15 -0700 |
commit | 31023e0a9fdba7ed6458caf2082dd6d82df6a56c (patch) | |
tree | 25f57ec0e4485c31226cfef5f7eab788f0cdaf99 | |
parent | i18n: am: mark more strings for translation (diff) | |
download | tgif-31023e0a9fdba7ed6458caf2082dd6d82df6a56c.tar.xz |
Remove dead code which contains bad gettext block
Found this dead code when I examine gettext messages in shell scripts
start with dash ('-' or '--'). An error will be raised for this case,
like:
$ gettext "-d option is no longer supported. Do not use."
gettext: missing arguments
Indead, this code has been left as dead for a long time, as Jonathan
points out:
The git am -d/--dotest option has errored out with a message
since e72c7406 (am: remove support for -d .dotest, 2008-03-04).
The error message about lack of support was eliminated along
with other cleanups (probably by mistake) a year later by
removing the option from the option table in 98ef23b3 (git-am:
minor cleanups, 2009-01-28).
But the code to handle -d and --dotest stayed around even though
ever since then it could not be tripped. Remove this dead code.
Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Reviewed-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-x | git-am.sh | 3 |
1 files changed, 0 insertions, 3 deletions
@@ -413,9 +413,6 @@ it will be removed. Please do not use it anymore." abort=t ;; --rebasing) rebasing=t threeway=t ;; - -d|--dotest) - die "$(gettext "-d option is no longer supported. Do not use.")" - ;; --resolvemsg) shift; resolvemsg=$1 ;; --whitespace|--directory|--exclude|--include) |