summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2017-07-28 15:23:32 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-07-28 15:51:29 -0700
commit2d90add5ad216807ec1433e5367fae730e74a4cb (patch)
tree0ab9d078d9d0d333cb57caaddc6091a7ed6313b9
parentconnect: reject ssh hostname that begins with a dash (diff)
downloadtgif-2d90add5ad216807ec1433e5367fae730e74a4cb.tar.xz
t5813: add test for hostname starting with dash
Per the explanation in the previous patch, this should be (and is) rejected. Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xt/t5813-proto-disable-ssh.sh9
1 files changed, 9 insertions, 0 deletions
diff --git a/t/t5813-proto-disable-ssh.sh b/t/t5813-proto-disable-ssh.sh
index a954ead8af..0ecdceecd6 100755
--- a/t/t5813-proto-disable-ssh.sh
+++ b/t/t5813-proto-disable-ssh.sh
@@ -17,4 +17,13 @@ test_proto "host:path" ssh "remote:repo.git"
test_proto "ssh://" ssh "ssh://remote$PWD/remote/repo.git"
test_proto "git+ssh://" ssh "git+ssh://remote$PWD/remote/repo.git"
+# Don't even bother setting up a "-remote" directory, as ssh would generally
+# complain about the bogus option rather than completing our request. Our
+# fake wrapper actually _can_ handle this case, but it's more robust to
+# simply confirm from its output that it did not run at all.
+test_expect_success 'hostnames starting with dash are rejected' '
+ test_must_fail git clone ssh://-remote/repo.git dash-host 2>stderr &&
+ ! grep ^ssh: stderr
+'
+
test_done