diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2019-01-18 13:49:56 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-01-18 13:49:56 -0800 |
| commit | 2c0a645d9e1f7442d17a9666e57d6e72b09bb51b (patch) | |
| tree | e4ef4146bea646eecdc66fe0794f0a6f0f4c9431 | |
| parent | Merge branch 'rs/loose-object-cache-perffix' (diff) | |
| parent | sha1-file: close fd of empty file in map_sha1_file_1() (diff) | |
| download | tgif-2c0a645d9e1f7442d17a9666e57d6e72b09bb51b.tar.xz | |
Merge branch 'rs/sha1-file-close-mapped-file-on-error'
Code clean-up.
* rs/sha1-file-close-mapped-file-on-error:
sha1-file: close fd of empty file in map_sha1_file_1()
| -rw-r--r-- | sha1-file.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sha1-file.c b/sha1-file.c index efcb2cbe74..386b96e1d7 100644 --- a/sha1-file.c +++ b/sha1-file.c @@ -960,6 +960,7 @@ static void *map_sha1_file_1(struct repository *r, const char *path, if (!*size) { /* mmap() is forbidden on empty files */ error(_("object file %s is empty"), path); + close(fd); return NULL; } map = xmmap(NULL, *size, PROT_READ, MAP_PRIVATE, fd, 0); |