diff options
| author |  Elia Pinto <gitter.spiros@gmail.com> | 2016-01-12 11:49:32 +0000 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2016-01-12 11:49:47 -0800 |
| commit | 27fe43e869f4ee8865beeedf6f2bbbab07cf0c7c (patch) | |
| tree | 58be40a050c26bfd76b4b26c425926e635c5f0b4 | |
| parent | t9137-git-svn-dcommit-clobber-series.sh: use the $( ... ) construct for comma... (diff) | |
| download | tgif-27fe43e869f4ee8865beeedf6f2bbbab07cf0c7c.tar.xz | |
t9138-git-svn-authors-prog.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t9138-git-svn-authors-prog.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t9138-git-svn-authors-prog.sh b/t/t9138-git-svn-authors-prog.sh index 2937f4c265..7d7e9d46bc 100755 --- a/t/t9138-git-svn-authors-prog.sh +++ b/t/t9138-git-svn-authors-prog.sh @@ -37,7 +37,7 @@ test_expect_success 'import authors with prog and file' ' test_expect_success 'imported 6 revisions successfully' ' ( cd x - test "`git rev-list refs/remotes/git-svn | wc -l`" -eq 6 + test "$(git rev-list refs/remotes/git-svn | wc -l)" -eq 6 ) ' |