summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Eric Sunshine <sunshine@sunshineco.com>2018-07-22 05:57:11 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-08-14 14:24:56 -0700
commit25668659bfd74a71de6dd27eac437a17ad72a315 (patch)
tree2cf7ec6edb821cac8ff214f0fc044a33dcfed34f
parentrange-diff: respect diff_option.file rather than assuming 'stdout' (diff)
downloadtgif-25668659bfd74a71de6dd27eac437a17ad72a315.tar.xz
range-diff: publish default creation factor
The range-diff back-end allows its heuristic to be tweaked via the "creation factor". git-range-diff, the only client of the back-end, defaults the factor to 60% (hard-coded in builtin/range-diff.c), but allows the user to override it with the --creation-factor option. Publish the default range factor to allow new callers of the range-diff back-end to default to the same value without duplicating the hard-coded constant, and to avoid worrying about various callers becoming out-of-sync if the default ever needs to change. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/range-diff.c2
-rw-r--r--range-diff.h2
2 files changed, 3 insertions, 1 deletions
diff --git a/builtin/range-diff.c b/builtin/range-diff.c
index f52d45d9d6..006e766726 100644
--- a/builtin/range-diff.c
+++ b/builtin/range-diff.c
@@ -18,7 +18,7 @@ static struct strbuf *output_prefix_cb(struct diff_options *opt, void *data)
int cmd_range_diff(int argc, const char **argv, const char *prefix)
{
- int creation_factor = 60;
+ int creation_factor = RANGE_DIFF_CREATION_FACTOR_DEFAULT;
struct diff_options diffopt = { NULL };
int simple_color = -1;
struct option options[] = {
diff --git a/range-diff.h b/range-diff.h
index 2407d46a30..f26de5d0b0 100644
--- a/range-diff.h
+++ b/range-diff.h
@@ -3,6 +3,8 @@
#include "diff.h"
+#define RANGE_DIFF_CREATION_FACTOR_DEFAULT 60
+
int show_range_diff(const char *range1, const char *range2,
int creation_factor, struct diff_options *diffopt);