summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2013-04-25 10:18:37 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2013-04-25 10:18:37 -0700
commit1afe6e404453586a1095ce0f3f7e899e62ab237f (patch)
tree0fd8043b2a0515929db2daf4fd519a1784b85681
parenttransport-helper: update remote helper namespace (diff)
downloadtgif-1afe6e404453586a1095ce0f3f7e899e62ab237f.tar.xz
t5801: "VAR=VAL shell_func args" is forbidden
It is not a portable expectation that a single-shot environment variable assignment works when calling a shell function, not a command. Set and export the variable before calling "test_must_fail git push" instead. This change would not hurt because this is the last command in the subprocess and the environment will not seep through to later tests without using a single-shot assignment. Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xt/t5801-remote-helpers.sh4
1 files changed, 3 insertions, 1 deletions
diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
index 4dcf744f97..c956abd865 100755
--- a/t/t5801-remote-helpers.sh
+++ b/t/t5801-remote-helpers.sh
@@ -118,7 +118,9 @@ test_expect_success 'pushing without refspecs' '
(cd local2 &&
echo content >>file &&
git commit -a -m ten &&
- GIT_REMOTE_TESTGIT_REFSPEC="" test_must_fail git push 2>../error) &&
+ GIT_REMOTE_TESTGIT_REFSPEC="" &&
+ export GIT_REMOTE_TESTGIT_REFSPEC &&
+ test_must_fail git push 2>../error) &&
grep "remote-helper doesn.t support push; refspec needed" error
'