diff options
author | Ingo Molnar <mingo@elte.hu> | 2011-04-28 12:19:02 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2011-04-28 13:18:30 -0700 |
commit | 1a812f3a701969824caf96803e160cbad6050520 (patch) | |
tree | 8cb85f640c68e9e91cacb1e4cb67e009df66ef61 | |
parent | Git 1.7.0 (diff) | |
download | tgif-1a812f3a701969824caf96803e160cbad6050520.tar.xz |
hashcmp(): inline memcmp() by hand to optimize
This is reported to speed "git gc" by 18%.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | cache.h | 18 |
1 files changed, 14 insertions, 4 deletions
@@ -614,14 +614,24 @@ extern char *sha1_pack_name(const unsigned char *sha1); extern char *sha1_pack_index_name(const unsigned char *sha1); extern const char *find_unique_abbrev(const unsigned char *sha1, int); extern const unsigned char null_sha1[20]; -static inline int is_null_sha1(const unsigned char *sha1) + +static inline int hashcmp(const unsigned char *sha1, const unsigned char *sha2) { - return !memcmp(sha1, null_sha1, 20); + int i; + + for (i = 0; i < 20; i++, sha1++, sha2++) { + if (*sha1 != *sha2) + return *sha1 - *sha2; + } + + return 0; } -static inline int hashcmp(const unsigned char *sha1, const unsigned char *sha2) + +static inline int is_null_sha1(const unsigned char *sha1) { - return memcmp(sha1, sha2, 20); + return !hashcmp(sha1, null_sha1); } + static inline void hashcpy(unsigned char *sha_dst, const unsigned char *sha_src) { memcpy(sha_dst, sha_src, 20); |