diff options
| author |  Jeff King <peff@peff.net> | 2010-08-31 11:56:36 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2010-08-31 09:53:56 -0700 |
| commit | 16034fbe59e88ec9592f73523cde97714d7c727c (patch) | |
| tree | c643ae49055e9986a734874f9f803d89625fac86 | |
| parent | gitweb: Don't die_error in git_tag after already printing headers (diff) | |
| download | tgif-16034fbe59e88ec9592f73523cde97714d7c727c.tar.xz | |
tests: make test_must_fail more verbose
Because test_must_fail fails when a command succeeds, the
command frequently does not produce any output (since, after
all, it thought it was succeeding). So let's have
test_must_fail itself report that a problem occurred.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | t/test-lib.sh | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/t/test-lib.sh b/t/test-lib.sh index 3a3d4c4723..285bfd8943 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -591,7 +591,15 @@ test_path_is_missing () { test_must_fail () { "$@" - test $? -gt 0 -a $? -le 129 -o $? -gt 192 + exit_code=$? + if test $exit_code = 0; then + echo >&2 "test_must_fail: command succeeded: $*" + return 1 + elif test $exit_code -gt 129 -a $exit_code -le 192; then + echo >&2 "test_must_fail: died by signal: $*" + return 1 + fi + return 0 } # Similar to test_must_fail, but tolerates success, too. This is |