diff options
| author |  Steffen Prohaska <prohaska@zib.de> | 2007-11-17 20:48:14 +0100 |
|---|---|---|
| committer |  Johannes Sixt <johannes.sixt@telecom.at> | 2008-06-26 08:47:17 +0200 |
| commit | 14086b0a13f5f5ac456cb9ae16a263f92908ae61 (patch) | |
| tree | 152dd1dc7acdcfec7c4883707001859560774c1e | |
| parent | Windows: Fix ntohl() related warnings about printf formatting (diff) | |
| download | tgif-14086b0a13f5f5ac456cb9ae16a263f92908ae61.tar.xz | |
compat/pread.c: Add a forward declaration to fix a warning
read_in_full()'s is used in compat/pread.c. read_in_full() is
declared in cache.h. But we can't include cache.h because too
many macros are defined there. Using read_in_full() without
including cache.h is dangerous because we wouldn't recognize if
its prototyp changed. gcc issues a warning about that.
This commit adds a forward declaration to git-compat-util.h.
git-compat-util.h is included by compat/pread.c _and_ cache.h.
Hence, changes in cache.h would be detected.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
| -rw-r--r-- | git-compat-util.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/git-compat-util.h b/git-compat-util.h index 58cdc087fa..51823ae7af 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -185,6 +185,12 @@ extern int git_munmap(void *start, size_t length); #define pread git_pread extern ssize_t git_pread(int fd, void *buf, size_t count, off_t offset); #endif +/* + * Forward decl that will remind us if its twin in cache.h changes. + * This function is used in compat/pread.c. But we can't include + * cache.h there. + */ +extern ssize_t read_in_full(int fd, void *buf, size_t count); #ifdef NO_SETENV #define setenv gitsetenv |