diff options
author | Derrick Stolee <dstolee@microsoft.com> | 2018-10-08 08:17:03 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-10-09 18:04:15 +0900 |
commit | 0ce4ff942125eabed3df694dc27922bec8177624 (patch) | |
tree | 6bfd68ded410da6ed750fd571d99604cc035a421 | |
parent | Sync with 2.19.1 (diff) | |
download | tgif-0ce4ff942125eabed3df694dc27922bec8177624.tar.xz |
midx: fix broken free() in close_midx()
When closing a multi-pack-index, we intend to close each pack-file
and free the struct packed_git that represents it. However, this
line was previously freeing the array of pointers, not the
pointer itself. This leads to a double-free issue.
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | midx.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -190,7 +190,7 @@ static void close_midx(struct multi_pack_index *m) for (i = 0; i < m->num_packs; i++) { if (m->packs[i]) { close_pack(m->packs[i]); - free(m->packs); + free(m->packs[i]); } } FREE_AND_NULL(m->packs); |