summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Sergey Organov <sorganov@gmail.com>2020-12-21 18:19:41 +0300
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-12-21 13:47:31 -0800
commit0c627f5d3cbcb7d85219d9a4cfc195f7d4230b3d (patch)
treed1fb75cc9b338e7c9253ee66f2ba58411f092987
parentdiff-merges: introduce revs->first_parent_merges flag (diff)
downloadtgif-0c627f5d3cbcb7d85219d9a4cfc195f7d4230b3d.tar.xz
diff-merges: handle imply -p on -c/--cc logic for log.c
Move logic that handles implying -p on -c/--cc from log_setup_revisions_tweak() to diff_merges_setup_revs(), where it belongs. Signed-off-by: Sergey Organov <sorganov@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/log.c4
-rw-r--r--diff-merges.c5
2 files changed, 5 insertions, 4 deletions
diff --git a/builtin/log.c b/builtin/log.c
index 63875c3aee..c3caf0955b 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -723,10 +723,6 @@ static void log_setup_revisions_tweak(struct rev_info *rev,
rev->prune_data.nr == 1)
rev->diffopt.flags.follow_renames = 1;
- /* Turn --cc/-c into -p --cc/-c when -p was not given */
- if (!rev->diffopt.output_format && rev->combine_merges)
- rev->diffopt.output_format = DIFF_FORMAT_PATCH;
-
if (rev->first_parent_only)
diff_merges_default_to_first_parent(rev);
}
diff --git a/diff-merges.c b/diff-merges.c
index fb591a9339..c48a65f8de 100644
--- a/diff-merges.c
+++ b/diff-merges.c
@@ -102,4 +102,9 @@ void diff_merges_setup_revs(struct rev_info *revs)
revs->ignore_merges = 1;
if (revs->combined_all_paths && !revs->combine_merges)
die("--combined-all-paths makes no sense without -c or --cc");
+ if (revs->combine_merges) {
+ /* Turn --cc/-c into -p --cc/-c when -p was not given */
+ if (!revs->diffopt.output_format)
+ revs->diffopt.output_format = DIFF_FORMAT_PATCH;
+ }
}