diff options
| author |  Giuseppe Bilotta <giuseppe.bilotta@gmail.com> | 2009-08-23 10:28:09 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2009-08-23 14:53:54 -0700 |
| commit | 01b89f0cd5d1c36990bbd3595b7d54c5f67d01e3 (patch) | |
| tree | 68e3b42ec547bda44b6f1c33ab248a377f6451be | |
| parent | Sync with 1.6.4.1 (diff) | |
| download | tgif-01b89f0cd5d1c36990bbd3595b7d54c5f67d01e3.tar.xz | |
gitweb: pull ref markes pull out of subject <a> element
Since 4afbaef (gitweb: ref markers link to named shortlogs, 2008-09-02),
ref markers that accompany the subject in views such as shortlog and
history point to something different from the subject itself. Therefore,
they should not be included in the same <a> element.
Benefits of the change are:
* better compliance to the XHTML standards, that forbid links within
links even though the restriction cannot be imposed via DTD; this also
benefits visualization in some older browsers;
* when hovering the subject, only the subject itself is underlined; when
hovering the ref markers, only the text in the hovered ref marker is
underlined; previously, hovering any written part of the subject column
led to complete underlying of everything at the same time, with
unpleasing effects.
Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | gitweb/gitweb.perl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index be7358fdeb..36cf4a216a 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1513,10 +1513,10 @@ sub format_subject_html { $long =~ s/[[:cntrl:]]/?/g; return $cgi->a({-href => $href, -class => "list subject", -title => to_utf8($long)}, - esc_html($short) . $extra); + esc_html($short)) . $extra; } else { return $cgi->a({-href => $href, -class => "list subject"}, - esc_html($long) . $extra); + esc_html($long)) . $extra; } } |