summaryrefslogtreecommitdiff
path: root/.github/CONTRIBUTING.md
diff options
context:
space:
mode:
authorLibravatar Martin Ågren <martin.agren@gmail.com>2017-09-23 01:34:54 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-09-24 10:06:08 +0900
commit4d01a7fa65c50e817a935396432e199b7a565f53 (patch)
tree32beebc4564f7b19405f3b8f2fefb70b59606836 /.github/CONTRIBUTING.md
parentobject_array: add and use `object_array_pop()` (diff)
downloadtgif-4d01a7fa65c50e817a935396432e199b7a565f53.tar.xz
pack-bitmap[-write]: use `object_array_clear()`, don't leak
Instead of setting the fields of rev->pending to 0/NULL, thereby leaking memory, call `object_array_clear(&rev->pending)`. In pack-bitmap.c, we make copies of those fields as `pending_nr` and `pending_e`. We never update the aliases and the original fields never change, so the aliases are not really needed and just make it harder than necessary to understand the code. While we're here, remove the aliases to make the code easier to follow. Signed-off-by: Martin Ågren <martin.agren@gmail.com> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to '.github/CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions