From 6a6a4993338262f87df34c9be051bfaac75c1829 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Sat, 26 Apr 2025 09:56:15 +0000 Subject: [performance] rewrite timelines to rely on new timeline cache type (#3941) * start work rewriting timeline cache type * further work rewriting timeline caching * more work integration new timeline code * remove old code * add local timeline, fix up merge conflicts * remove old use of go-bytes * implement new timeline code into more areas of codebase, pull in latest go-mangler, go-mutexes, go-structr * remove old timeline package, add local timeline cache * remove references to old timeline types that needed starting up in tests * start adding page validation * fix test-identified timeline cache package issues * fix up more tests, fix missing required changes, etc * add exclusion for test.out in gitignore * clarify some things better in code comments * tweak cache size limits * fix list timeline cache fetching * further list timeline fixes * linter, ssssssssshhhhhhhhhhhh please * fix linter hints * reslice the output if it's beyond length of 'lim' * remove old timeline initialization code, bump go-structr to v0.9.4 * continued from previous commit * improved code comments * don't allow multiple entries for BoostOfID values to prevent repeated boosts of same boosts * finish writing more code comments * some variable renaming, for ease of following * change the way we update lo,hi paging values during timeline load * improved code comments for updated / returned lo , hi paging values * finish writing code comments for the StatusTimeline{} type itself * fill in more code comments * update go-structr version to latest with changed timeline unique indexing logic * have a local and public timeline *per user* * rewrite calls to public / local timeline calls * remove the zero length check, as lo, hi values might still be set * simplify timeline cache loading, fix lo/hi returns, fix timeline invalidation side-effects missing for some federated actions * swap the lo, hi values :facepalm: * add (now) missing slice reverse of tag timeline statuses when paging ASC * remove local / public caches (is out of scope for this work), share more timeline code * remove unnecessary change * again, remove more unused code * remove unused function to appease the linter * move boost checking to prepare function * fix use of timeline.lastOrder, fix incorrect range functions used * remove comments for repeat code * remove the boost logic from prepare function * do a maximum of 5 loads, not 10 * add repeat boost filtering logic, update go-structr, general improvements * more code comments * add important note * fix timeline tests now that timelines are returned in page order * remove unused field * add StatusTimeline{} tests * add more status timeline tests * start adding preloading support * ensure repeat boosts are marked in preloaded entries * share a bunch of the database load code in timeline cache, don't clear timelines on relationship change * add logic to allow dynamic clear / preloading of timelines * comment-out unused functions, but leave in place as we might end-up using them * fix timeline preload state check * much improved status timeline code comments * more code comments, don't bother inserting statuses if timeline not preloaded * shift around some logic to make sure things aren't accidentally left set * finish writing code comments * remove trim-after-insert behaviour * fix-up some comments referring to old logic * remove unsetting of lo, hi * fix preload repeatBoost checking logic * don't return on status filter errors, these are usually transient * better concurrency safety in Clear() and Done() * fix test broken due to addition of preloader * fix repeatBoost logic that doesn't account for already-hidden repeatBoosts * ensure edit submodels are dropped on cache insertion * update code-comment to expand CAS accronym * use a plus1hULID() instead of 24h * remove unused functions * add note that public / local timeline requester can be nil * fix incorrect visibility filtering of tag timeline statuses * ensure we filter home timeline statuses on local only * some small re-orderings to confirm query params in correct places * fix the local only home timeline filter func --- vendor/codeberg.org/gruf/go-bytes/buffer.go | 131 ---------------------------- 1 file changed, 131 deletions(-) delete mode 100644 vendor/codeberg.org/gruf/go-bytes/buffer.go (limited to 'vendor/codeberg.org/gruf/go-bytes/buffer.go') diff --git a/vendor/codeberg.org/gruf/go-bytes/buffer.go b/vendor/codeberg.org/gruf/go-bytes/buffer.go deleted file mode 100644 index 5c3b2cb5b..000000000 --- a/vendor/codeberg.org/gruf/go-bytes/buffer.go +++ /dev/null @@ -1,131 +0,0 @@ -package bytes - -import ( - "unicode/utf8" -) - -// Buffer is a very simple buffer implementation that allows -// access to and reslicing of the underlying byte slice. -type Buffer struct { - B []byte -} - -func NewBuffer(b []byte) Buffer { - return Buffer{ - B: b, - } -} - -func (b *Buffer) Write(p []byte) (int, error) { - b.Grow(len(p)) - return copy(b.B[b.Len()-len(p):], p), nil -} - -func (b *Buffer) WriteString(s string) (int, error) { - b.Grow(len(s)) - return copy(b.B[b.Len()-len(s):], s), nil -} - -func (b *Buffer) WriteByte(c byte) error { - l := b.Len() - b.Grow(1) - b.B[l] = c - return nil -} - -func (b *Buffer) WriteRune(r rune) (int, error) { - if r < utf8.RuneSelf { - b.WriteByte(byte(r)) - return 1, nil - } - - l := b.Len() - b.Grow(utf8.UTFMax) - n := utf8.EncodeRune(b.B[l:b.Len()], r) - b.B = b.B[:l+n] - - return n, nil -} - -func (b *Buffer) WriteAt(p []byte, start int64) (int, error) { - b.Grow(len(p) - int(int64(b.Len())-start)) - return copy(b.B[start:], p), nil -} - -func (b *Buffer) WriteStringAt(s string, start int64) (int, error) { - b.Grow(len(s) - int(int64(b.Len())-start)) - return copy(b.B[start:], s), nil -} - -func (b *Buffer) Truncate(size int) { - b.B = b.B[:b.Len()-size] -} - -func (b *Buffer) ShiftByte(index int) { - copy(b.B[index:], b.B[index+1:]) -} - -func (b *Buffer) Shift(start int64, size int) { - copy(b.B[start:], b.B[start+int64(size):]) -} - -func (b *Buffer) DeleteByte(index int) { - b.ShiftByte(index) - b.Truncate(1) -} - -func (b *Buffer) Delete(start int64, size int) { - b.Shift(start, size) - b.Truncate(size) -} - -func (b *Buffer) InsertByte(index int64, c byte) { - l := b.Len() - b.Grow(1) - copy(b.B[index+1:], b.B[index:l]) - b.B[index] = c -} - -func (b *Buffer) Insert(index int64, p []byte) { - l := b.Len() - b.Grow(len(p)) - copy(b.B[index+int64(len(p)):], b.B[index:l]) - copy(b.B[index:], p) -} - -func (b *Buffer) Bytes() []byte { - return b.B -} - -func (b *Buffer) String() string { - return string(b.B) -} - -func (b *Buffer) StringPtr() string { - return BytesToString(b.B) -} - -func (b *Buffer) Cap() int { - return cap(b.B) -} - -func (b *Buffer) Len() int { - return len(b.B) -} - -func (b *Buffer) Reset() { - b.B = b.B[:0] -} - -func (b *Buffer) Grow(size int) { - b.Guarantee(size) - b.B = b.B[:b.Len()+size] -} - -func (b *Buffer) Guarantee(size int) { - if size > b.Cap()-b.Len() { - nb := make([]byte, 2*b.Cap()+size) - copy(nb, b.B) - b.B = nb[:b.Len()] - } -} -- cgit v1.2.3