From de6e3e5f2a8ea639d76e310a11cb9bc093fef3a9 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Tue, 28 Mar 2023 14:03:14 +0100 Subject: [performance] refactoring + add fave / follow / request / visibility caching (#1607) * refactor visibility checking, add caching for visibility * invalidate visibility cache items on account / status deletes * fix requester ID passed to visibility cache nil ptr * de-interface caches, fix home / public timeline caching + visibility * finish adding code comments for visibility filter * fix angry goconst linter warnings * actually finish adding filter visibility code comments for timeline functions * move home timeline status author check to after visibility * remove now-unused code * add more code comments * add TODO code comment, update printed cache start names * update printed cache names on stop * start adding separate follow(request) delete db functions, add specific visibility cache tests * add relationship type caching * fix getting local account follows / followed-bys, other small codebase improvements * simplify invalidation using cache hooks, add more GetAccountBy___() functions * fix boosting to return 404 if not boostable but no error (to not leak status ID) * remove dead code * improved placement of cache invalidation * update license headers * add example follow, follow-request config entries * add example visibility cache configuration to config file * use specific PutFollowRequest() instead of just Put() * add tests for all GetAccountBy() * add GetBlockBy() tests * update block to check primitive fields * update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests * fix copy-pasted code * update envparsing test * whitespace * fix bun struct tag * add license header to gtscontext * fix old license header * improved error creation to not use fmt.Errorf() when not needed * fix various rebase conflicts, fix account test * remove commented-out code, fix-up mention caching * fix mention select bun statement * ensure mention target account populated, pass in context to customrenderer logging * remove more uncommented code, fix typeutil test * add statusfave database model caching * add status fave cache configuration * add status fave cache example config * woops, catch missed error. nice catch linter! * add back testrig panic on nil db * update example configuration to match defaults, slight tweak to cache configuration defaults * update envparsing test with new defaults * fetch followingget to use the follow target account * use accounnt.IsLocal() instead of empty domain check * use constants for the cache visibility type check * use bun.In() for notification type restriction in db query * include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable()) * use bun query building for nested select statements to ensure working with postgres * update public timeline future status checks to match visibility filter * same as previous, for home timeline * update public timeline tests to dynamically check for appropriate statuses * migrate accounts to allow unique constraint on public_key * provide minimal account with publicKey --------- Signed-off-by: kim Co-authored-by: tsmethurst --- test/envparsing.sh | 72 +++++++++++++++++++++++++++++++----------------------- 1 file changed, 42 insertions(+), 30 deletions(-) (limited to 'test') diff --git a/test/envparsing.sh b/test/envparsing.sh index 361866881..2a9be5155 100755 --- a/test/envparsing.sh +++ b/test/envparsing.sh @@ -20,43 +20,55 @@ EXPECT=$(cat <<"EOF" "account-max-size": 99, "account-sweep-freq": 1000000000, "account-ttl": 10800000000000, - "block-max-size": 100, - "block-sweep-freq": 30000000000, - "block-ttl": 300000000000, - "domain-block-max-size": 1000, + "block-max-size": 1000, + "block-sweep-freq": 60000000000, + "block-ttl": 1800000000000, + "domain-block-max-size": 2000, "domain-block-sweep-freq": 60000000000, "domain-block-ttl": 86400000000000, "emoji-category-max-size": 100, - "emoji-category-sweep-freq": 30000000000, - "emoji-category-ttl": 300000000000, - "emoji-max-size": 500, - "emoji-sweep-freq": 30000000000, - "emoji-ttl": 300000000000, - "media-max-size": 500, - "media-sweep-freq": 30000000000, - "media-ttl": 300000000000, - "mention-max-size": 500, - "mention-sweep-freq": 30000000000, - "mention-ttl": 300000000000, - "notification-max-size": 500, - "notification-sweep-freq": 30000000000, - "notification-ttl": 300000000000, + "emoji-category-sweep-freq": 60000000000, + "emoji-category-ttl": 1800000000000, + "emoji-max-size": 2000, + "emoji-sweep-freq": 60000000000, + "emoji-ttl": 1800000000000, + "follow-max-size": 2000, + "follow-request-max-size": 2000, + "follow-request-sweep-freq": 60000000000, + "follow-request-ttl": 1800000000000, + "follow-sweep-freq": 60000000000, + "follow-ttl": 1800000000000, + "media-max-size": 1000, + "media-sweep-freq": 60000000000, + "media-ttl": 1800000000000, + "mention-max-size": 2000, + "mention-sweep-freq": 60000000000, + "mention-ttl": 1800000000000, + "notification-max-size": 1000, + "notification-sweep-freq": 60000000000, + "notification-ttl": 1800000000000, "report-max-size": 100, - "report-sweep-freq": 30000000000, - "report-ttl": 300000000000, - "status-max-size": 500, - "status-sweep-freq": 30000000000, - "status-ttl": 300000000000, - "tombstone-max-size": 100, - "tombstone-sweep-freq": 30000000000, - "tombstone-ttl": 300000000000, - "user-max-size": 100, - "user-sweep-freq": 30000000000, - "user-ttl": 300000000000, + "report-sweep-freq": 60000000000, + "report-ttl": 1800000000000, + "status-fave-max-size": 2000, + "status-fave-sweep-freq": 60000000000, + "status-fave-ttl": 1800000000000, + "status-max-size": 2000, + "status-sweep-freq": 60000000000, + "status-ttl": 1800000000000, + "tombstone-max-size": 500, + "tombstone-sweep-freq": 60000000000, + "tombstone-ttl": 1800000000000, + "user-max-size": 500, + "user-sweep-freq": 60000000000, + "user-ttl": 1800000000000, "webfinger-max-size": 250, "webfinger-sweep-freq": 900000000000, "webfinger-ttl": 86400000000000 - } + }, + "visibility-max-size": 2000, + "visibility-sweep-freq": 60000000000, + "visibility-ttl": 1800000000000 }, "config-path": "internal/config/testdata/test.yaml", "db-address": ":memory:", -- cgit v1.2.3