From 18f82b83de1dd7f601e7209e2c1b9c22fda5a4cd Mon Sep 17 00:00:00 2001 From: nopjmp Date: Tue, 6 May 2025 09:54:50 +0000 Subject: [feature] add ability to change s3 bucket lookup type (#4120) # Description This pull request implements the ability to specify the S3 bucket lookup type that is passed to the minio-go library. By default, minio-go uses a regex on the endpoint to see if it is a host that supports DNS access or not. Tigris and others are moving away from path style bucket access to DNS style bucket access using subdomains. This keeps the default as 'auto' to allow existing users to not need to modify their configurations. closes #3942 ## Checklist - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [ ] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [ ] I/we have commented the added code, particularly in hard-to-understand areas. - [x] I/we have made any necessary changes to documentation. - [ ] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Co-authored-by: tobi Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4120 Reviewed-by: kim Co-authored-by: nopjmp Co-committed-by: nopjmp --- test/envparsing.sh | 2 ++ 1 file changed, 2 insertions(+) (limited to 'test') diff --git a/test/envparsing.sh b/test/envparsing.sh index 66295f1f6..088ffc0b3 100755 --- a/test/envparsing.sh +++ b/test/envparsing.sh @@ -187,6 +187,7 @@ EXPECT=$(cat << "EOF" "storage-local-base-path": "/root/store", "storage-s3-access-key": "minio", "storage-s3-bucket": "gts", + "storage-s3-bucket-lookup": "auto", "storage-s3-endpoint": "localhost:9000", "storage-s3-proxy": true, "storage-s3-redirect-url": "", @@ -276,6 +277,7 @@ GTS_STORAGE_S3_ACCESS_KEY='minio' \ GTS_STORAGE_S3_SECRET_KEY='miniostorage' \ GTS_STORAGE_S3_ENDPOINT='localhost:9000' \ GTS_STORAGE_S3_USE_SSL='false' \ +GTS_STORAGE_S3_BUCKET_LOOKUP='auto' \ GTS_STORAGE_S3_PROXY='true' \ GTS_STORAGE_S3_REDIRECT_URL='' \ GTS_STORAGE_S3_BUCKET='gts' \ -- cgit v1.3