From 5f3e0957179eddd088e82b8f8f493164cbc9ce37 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Tue, 25 Jul 2023 09:34:05 +0100 Subject: [performance] retry db queries on busy errors (#2025) * catch SQLITE_BUSY errors, wrap bun.DB to use our own busy retrier, remove unnecessary db.Error type Signed-off-by: kim * remove dead code Signed-off-by: kim * remove more dead code, add missing error arguments Signed-off-by: kim * update sqlite to use maxOpenConns() Signed-off-by: kim * add uncommitted changes Signed-off-by: kim * use direct calls-through for the ConnIface to make sure we don't double query hook Signed-off-by: kim * expose underlying bun.DB better Signed-off-by: kim * retry on the correct busy error Signed-off-by: kim * use longer possible maxRetries for db retry-backoff Signed-off-by: kim * remove the note regarding max-open-conns only applying to postgres Signed-off-by: kim * improved code commenting Signed-off-by: kim * remove unnecessary infof call (just use info) Signed-off-by: kim * rename DBConn to WrappedDB to better follow sql package name conventions Signed-off-by: kim * update test error string checks Signed-off-by: kim * shush linter Signed-off-by: kim * update backoff logic to be more transparent Signed-off-by: kim --------- Signed-off-by: kim --- internal/web/web.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'internal/web/web.go') diff --git a/internal/web/web.go b/internal/web/web.go index c53433730..5c1c4750d 100644 --- a/internal/web/web.go +++ b/internal/web/web.go @@ -62,7 +62,7 @@ const ( type Module struct { processor *processing.Processor eTagCache cache.Cache[string, eTagCacheEntry] - isURIBlocked func(context.Context, *url.URL) (bool, db.Error) + isURIBlocked func(context.Context, *url.URL) (bool, error) } func New(db db.DB, processor *processing.Processor) *Module { -- cgit v1.2.3