From 79ccd8fd8acd09f78385cda799e9049cbc59de0f Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Mon, 22 Nov 2021 14:40:23 +0100 Subject: Fix mentioned accounts visibility bug (#323) * update other tests * set test status to followers_only * add test dm * fix mentioned accounts not being added to relevantAccounts * add some visibility tests for statuses --- internal/visibility/statusvisible_test.go | 115 ++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+) create mode 100644 internal/visibility/statusvisible_test.go (limited to 'internal/visibility/statusvisible_test.go') diff --git a/internal/visibility/statusvisible_test.go b/internal/visibility/statusvisible_test.go new file mode 100644 index 000000000..f92bcd62f --- /dev/null +++ b/internal/visibility/statusvisible_test.go @@ -0,0 +1,115 @@ +/* + GoToSocial + Copyright (C) 2021 GoToSocial Authors admin@gotosocial.org + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU Affero General Public License for more details. + + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see . +*/ + +package visibility_test + +import ( + "context" + "testing" + + "github.com/stretchr/testify/suite" +) + +type StatusVisibleTestSuite struct { + FilterStandardTestSuite +} + +func (suite *StatusVisibleTestSuite) TestOwnStatusVisible() { + testStatus := suite.testStatuses["local_account_1_status_1"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(visible) +} + +func (suite *StatusVisibleTestSuite) TestOwnDMVisible() { + ctx := context.Background() + + testStatusID := suite.testStatuses["local_account_2_status_6"].ID + testStatus, err := suite.db.GetStatusByID(ctx, testStatusID) + suite.NoError(err) + testAccount := suite.testAccounts["local_account_2"] + + visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(visible) +} + +func (suite *StatusVisibleTestSuite) TestDMVisibleToTarget() { + ctx := context.Background() + + testStatusID := suite.testStatuses["local_account_2_status_6"].ID + testStatus, err := suite.db.GetStatusByID(ctx, testStatusID) + suite.NoError(err) + testAccount := suite.testAccounts["local_account_1"] + + visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(visible) +} + +func (suite *StatusVisibleTestSuite) TestDMNotVisibleIfNotMentioned() { + ctx := context.Background() + + testStatusID := suite.testStatuses["local_account_2_status_6"].ID + testStatus, err := suite.db.GetStatusByID(ctx, testStatusID) + suite.NoError(err) + testAccount := suite.testAccounts["admin_account"] + + visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.False(visible) +} + +func (suite *StatusVisibleTestSuite) TestStatusNotVisibleIfNotMutuals() { + ctx := context.Background() + + testStatusID := suite.testStatuses["local_account_1_status_4"].ID + testStatus, err := suite.db.GetStatusByID(ctx, testStatusID) + suite.NoError(err) + testAccount := suite.testAccounts["local_account_2"] + + visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.False(visible) +} + +func (suite *StatusVisibleTestSuite) TestStatusNotVisibleIfNotFollowing() { + ctx := context.Background() + + testStatusID := suite.testStatuses["local_account_1_status_5"].ID + testStatus, err := suite.db.GetStatusByID(ctx, testStatusID) + suite.NoError(err) + testAccount := suite.testAccounts["admin_account"] + + visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.False(visible) +} + +func TestStatusVisibleTestSuite(t *testing.T) { + suite.Run(t, new(StatusVisibleTestSuite)) +} -- cgit v1.2.3