From 9265a09a656196e2a94c73e32c7b79399411a79e Mon Sep 17 00:00:00 2001 From: Adelie Paull <1208865+i-am-a-paull@users.noreply.github.com> Date: Mon, 2 May 2022 09:23:37 -0400 Subject: [bugfix] Allow self-boosting for any visibility but direct (#510) * create visibility filter for boostability and allow self-boosting for any visbility but direct messages * add a followers-only status to local_account_2 * fix typo in comment * add license header, unwrap errors, be explicit about non-boostable visibility settings to avoid rogue boosting from miscoded clients, use ID compare for checking if self-boosting * add tests for statusboostable filter * fix tests that were affected by adding a new status to the test data * fix the rest of tests affected by adding a status to the textrig data --- internal/visibility/statusboostable_test.go | 155 ++++++++++++++++++++++++++++ 1 file changed, 155 insertions(+) create mode 100644 internal/visibility/statusboostable_test.go (limited to 'internal/visibility/statusboostable_test.go') diff --git a/internal/visibility/statusboostable_test.go b/internal/visibility/statusboostable_test.go new file mode 100644 index 000000000..f39467676 --- /dev/null +++ b/internal/visibility/statusboostable_test.go @@ -0,0 +1,155 @@ +/* + GoToSocial + Copyright (C) 2021-2022 GoToSocial Authors admin@gotosocial.org + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU Affero General Public License for more details. + + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see . +*/ + +package visibility_test + +import ( + "context" + "testing" + + "github.com/stretchr/testify/suite" +) + +type StatusBoostableTestSuite struct { + FilterStandardTestSuite +} + +func (suite *StatusBoostableTestSuite) TestOwnPublicBoostable() { + testStatus := suite.testStatuses["local_account_1_status_1"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOwnUnlockedBoostable() { + testStatus := suite.testStatuses["local_account_1_status_2"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOwnMutualsOnlyNonInteractiveBoostable() { + testStatus := suite.testStatuses["local_account_1_status_3"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOwnMutualsOnlyBoostable() { + testStatus := suite.testStatuses["local_account_1_status_4"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOwnFollowersOnlyBoostable() { + testStatus := suite.testStatuses["local_account_1_status_5"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOwnDirectNotBoostable() { + testStatus := suite.testStatuses["local_account_2_status_6"] + testAccount := suite.testAccounts["local_account_2"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.False(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOtherPublicBoostable() { + testStatus := suite.testStatuses["local_account_2_status_1"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOtherUnlistedBoostable() { + testStatus := suite.testStatuses["local_account_1_status_2"] + testAccount := suite.testAccounts["local_account_2"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.True(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOtherFollowersOnlyNotBoostable() { + testStatus := suite.testStatuses["local_account_2_status_7"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.False(boostable) +} + +func (suite *StatusBoostableTestSuite) TestOtherDirectNotBoostable() { + testStatus := suite.testStatuses["local_account_2_status_6"] + testAccount := suite.testAccounts["local_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.NoError(err) + + suite.False(boostable) +} + +func (suite *StatusBoostableTestSuite) TestRemoteFollowersOnlyNotVisibleError() { + testStatus := suite.testStatuses["local_account_1_status_5"] + testAccount := suite.testAccounts["remote_account_1"] + ctx := context.Background() + + boostable, err := suite.filter.StatusBoostable(ctx, testStatus, testAccount) + suite.Assert().Error(err) + + suite.False(boostable) +} + +func TestStatusBoostableTestSuite(t *testing.T) { + suite.Run(t, new(StatusBoostableTestSuite)) +} -- cgit v1.2.3