From 2b6b9cdf832078980ca668126bce3b4fcfff02a9 Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Fri, 29 Sep 2023 15:31:10 +0200 Subject: [bugfix] Fix paging for empty items (#2236) * use minID properly for public timeline * return paged response properly even when 0 items * use gtserror * page more consistently (for now) * test * aaa --- internal/util/paging_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'internal/util/paging_test.go') diff --git a/internal/util/paging_test.go b/internal/util/paging_test.go index 685db14ba..66c5b2c56 100644 --- a/internal/util/paging_test.go +++ b/internal/util/paging_test.go @@ -118,6 +118,7 @@ func (suite *PagingSuite) TestPagingNoItems() { config.SetHost("example.org") params := util.PageableResponseParams{ + Path: "/api/v1/accounts/01H11KA68PM4NNYJEG0FJQ90R3/statuses", NextMaxIDValue: "01H11KA1DM2VH3747YDE7FV5HN", PrevMinIDValue: "01H11KBBVRRDYYC5KEPME1NP5R", Limit: 10, @@ -129,9 +130,9 @@ func (suite *PagingSuite) TestPagingNoItems() { } suite.Empty(resp.Items) - suite.Empty(resp.LinkHeader) - suite.Empty(resp.NextLink) - suite.Empty(resp.PrevLink) + suite.Equal(`; rel="next", ; rel="prev"`, resp.LinkHeader) + suite.Equal(`https://example.org/api/v1/accounts/01H11KA68PM4NNYJEG0FJQ90R3/statuses?limit=10&max_id=01H11KA1DM2VH3747YDE7FV5HN`, resp.NextLink) + suite.Equal(`https://example.org/api/v1/accounts/01H11KA68PM4NNYJEG0FJQ90R3/statuses?limit=10&min_id=01H11KBBVRRDYYC5KEPME1NP5R`, resp.PrevLink) } func TestPagingSuite(t *testing.T) { -- cgit v1.2.3