From 6f24205a26bde03e73055fd7af369352103c390f Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Mon, 7 Apr 2025 13:52:24 +0200 Subject: [bugfix] Don't assume `"manuallyApprovesFollowers": true` if not set (#3978) * [bugfix] Don't assume `"manuallyApprovesFollowers": true` if not set * whoops, tests --- internal/typeutils/astointernal.go | 2 +- internal/typeutils/astointernal_test.go | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) (limited to 'internal/typeutils') diff --git a/internal/typeutils/astointernal.go b/internal/typeutils/astointernal.go index 80e1de378..59c696f11 100644 --- a/internal/typeutils/astointernal.go +++ b/internal/typeutils/astointernal.go @@ -154,7 +154,7 @@ func (c *Converter) ASRepresentationToAccount( // Assume not memorial (todo) acct.MemorializedAt = time.Time{} - // Extract 'manuallyApprovesFollowers' aka locked account (default = true). + // Extract 'manuallyApprovesFollowers' aka locked account (default = false). manuallyApprovesFollowers := ap.GetManuallyApprovesFollowers(accountable) acct.Locked = &manuallyApprovesFollowers diff --git a/internal/typeutils/astointernal_test.go b/internal/typeutils/astointernal_test.go index 589a22df9..b49c14299 100644 --- a/internal/typeutils/astointernal_test.go +++ b/internal/typeutils/astointernal_test.go @@ -613,7 +613,7 @@ func (suite *ASToInternalTestSuite) TestParseHonkAccount() { suite.Equal("https://honk.example.org/u/honk_user", acct.URL) suite.Equal("honk_user", acct.Username) suite.Equal("honk.example.org", acct.Domain) - suite.True(*acct.Locked) + suite.False(*acct.Locked) suite.False(*acct.Discoverable) // Store the account representation. @@ -632,7 +632,7 @@ func (suite *ASToInternalTestSuite) TestParseHonkAccount() { suite.Equal("https://honk.example.org/u/honk_user", acct.URL) suite.Equal("honk_user", acct.Username) suite.Equal("honk.example.org", acct.Domain) - suite.True(*acct.Locked) + suite.False(*acct.Locked) suite.False(*acct.Discoverable) // Check DB version. @@ -649,7 +649,7 @@ func (suite *ASToInternalTestSuite) TestParseHonkAccount() { suite.Equal("https://honk.example.org/u/honk_user", dbAcct.URL) suite.Equal("honk_user", dbAcct.Username) suite.Equal("honk.example.org", dbAcct.Domain) - suite.True(*dbAcct.Locked) + suite.False(*dbAcct.Locked) suite.False(*dbAcct.Discoverable) // Update the account. @@ -666,7 +666,7 @@ func (suite *ASToInternalTestSuite) TestParseHonkAccount() { suite.Equal("https://honk.example.org/u/honk_user", acct.URL) suite.Equal("honk_user", acct.Username) suite.Equal("honk.example.org", acct.Domain) - suite.True(*acct.Locked) + suite.False(*acct.Locked) suite.False(*acct.Discoverable) // Check DB version. @@ -683,7 +683,7 @@ func (suite *ASToInternalTestSuite) TestParseHonkAccount() { suite.Equal("https://honk.example.org/u/honk_user", dbAcct.URL) suite.Equal("honk_user", dbAcct.Username) suite.Equal("honk.example.org", dbAcct.Domain) - suite.True(*dbAcct.Locked) + suite.False(*dbAcct.Locked) suite.False(*dbAcct.Discoverable) // Clear caches. @@ -703,7 +703,7 @@ func (suite *ASToInternalTestSuite) TestParseHonkAccount() { suite.Equal("https://honk.example.org/u/honk_user", dbAcct.URL) suite.Equal("honk_user", dbAcct.Username) suite.Equal("honk.example.org", dbAcct.Domain) - suite.True(*dbAcct.Locked) + suite.False(*dbAcct.Locked) suite.False(*dbAcct.Discoverable) } -- cgit v1.2.3