From 23fc70f4e68730b7eec91d58dac54ec00099ed8d Mon Sep 17 00:00:00 2001
From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com>
Date: Thu, 5 Dec 2024 13:35:07 +0000
Subject: [feature] add support for receiving federated status edits (#3597)

* add support for extracting Updated field from Statusable implementers

* add support for status edits in the database, and update status dereferencer to handle them

* remove unused AdditionalInfo{}.CreatedAt

* remove unused AdditionalEmojiInfo{}.CreatedAt

* update new mention creation to use status.UpdatedAt

* remove mention.UpdatedAt, fixes related to NewULIDFromTime() change

* add migration to remove Mention{}.UpdatedAt field

* add migration to add the StatusEdit{} table

* start adding tests, add delete function for status edits

* add more of status edit migrations, fill in more of the necessary edit delete functionality

* remove unused function

* allow generating gotosocial compatible ulid via CLI with `go run ./cmd/gen-ulid`

* add StatusEdit{} test models

* fix new statusedits sql

* use model instead of table name

* actually remove the Mention.UpdatedAt field...

* fix tests now new models are added, add more status edit DB tests

* fix panic wording

* add test for deleting status edits

* don't automatically set `updated_at` field on updated statuses

* flesh out more of the dereferencer status edit tests, ensure updated at field set on outgoing AS statuses

* remove media_attachments.updated_at column

* fix up more tests, further complete the dereferencer status edit tests

* update more status serialization tests not expecting 'updated' AS property

* gah!! json serialization tests!!

* undo some gtscontext wrapping changes

* more serialization test fixing :smiling_face_with_tear:

* more test fixing, ensure the edit.status_id field is actually set :facepalm:

* fix status edit test

* grrr linter

* add edited_at field to apimodel status

* remove the choice of paging on the timeline public filtered test (otherwise it needs updating every time you add statuses ...)

* ensure that status.updated_at always fits chronologically

* fix more serialization tests ...

* add more code comments

* fix envparsing

* update swagger file

* properly handle media description changes during status edits

* slight formatting tweak

* code comment
---
 internal/typeutils/internal.go | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

(limited to 'internal/typeutils/internal.go')

diff --git a/internal/typeutils/internal.go b/internal/typeutils/internal.go
index ccde6a38f..573495e0a 100644
--- a/internal/typeutils/internal.go
+++ b/internal/typeutils/internal.go
@@ -104,14 +104,8 @@ func (c *Converter) StatusToBoost(
 	return boost, nil
 }
 
-func StatusToInteractionRequest(
-	ctx context.Context,
-	status *gtsmodel.Status,
-) (*gtsmodel.InteractionRequest, error) {
-	reqID, err := id.NewULIDFromTime(status.CreatedAt)
-	if err != nil {
-		return nil, gtserror.Newf("error generating ID: %w", err)
-	}
+func StatusToInteractionRequest(status *gtsmodel.Status) *gtsmodel.InteractionRequest {
+	reqID := id.NewULIDFromTime(status.CreatedAt)
 
 	var (
 		targetID        string
@@ -154,17 +148,11 @@ func StatusToInteractionRequest(
 		InteractionType:      interactionType,
 		Reply:                reply,
 		Announce:             announce,
-	}, nil
+	}
 }
 
-func StatusFaveToInteractionRequest(
-	ctx context.Context,
-	fave *gtsmodel.StatusFave,
-) (*gtsmodel.InteractionRequest, error) {
-	reqID, err := id.NewULIDFromTime(fave.CreatedAt)
-	if err != nil {
-		return nil, gtserror.Newf("error generating ID: %w", err)
-	}
+func StatusFaveToInteractionRequest(fave *gtsmodel.StatusFave) *gtsmodel.InteractionRequest {
+	reqID := id.NewULIDFromTime(fave.CreatedAt)
 
 	return &gtsmodel.InteractionRequest{
 		ID:                   reqID,
@@ -178,7 +166,7 @@ func StatusFaveToInteractionRequest(
 		InteractionURI:       fave.URI,
 		InteractionType:      gtsmodel.InteractionLike,
 		Like:                 fave,
-	}, nil
+	}
 }
 
 func (c *Converter) StatusToSinBinStatus(
-- 
cgit v1.2.3