From 14ef09809942800db57de87fe3963770a56b585b Mon Sep 17 00:00:00 2001 From: Daenney Date: Thu, 7 Sep 2023 13:20:37 +0200 Subject: [feature] Support OTLP HTTP, drop Jaeger (#2184) * [feature] Add http trace exporter, drop Jaeger Jaeger supports ingesting traces using the OpenTelemetry gRPC or HTTP methods. The Jaeger project has deprecated the old jaeger transport. * Add support for submitting traces over HTTP * Drop support for the old Jaeger protocol * Upgrade the trace libraries to v1.17 Fixes: #2176 Fixes: #2179 --- internal/tracing/tracing.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'internal/tracing/tracing.go') diff --git a/internal/tracing/tracing.go b/internal/tracing/tracing.go index 16e5a5eb5..a0b25f487 100644 --- a/internal/tracing/tracing.go +++ b/internal/tracing/tracing.go @@ -29,8 +29,8 @@ import ( "github.com/uptrace/bun/extra/bunotel" "go.opentelemetry.io/otel" "go.opentelemetry.io/otel/attribute" - "go.opentelemetry.io/otel/exporters/jaeger" "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc" + "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp" "go.opentelemetry.io/otel/propagation" "go.opentelemetry.io/otel/sdk/resource" "go.opentelemetry.io/otel/sdk/trace" @@ -69,8 +69,14 @@ func Initialize() error { return fmt.Errorf("building tracing exporter: %w", err) } tpo = trace.WithBatcher(exp) - case "jaeger": - exp, err := jaeger.New(jaeger.WithCollectorEndpoint(jaeger.WithEndpoint(config.GetTracingEndpoint()))) + case "http": + opts := []otlptracehttp.Option{ + otlptracehttp.WithEndpoint(config.GetTracingEndpoint()), + } + if insecure { + opts = append(opts, otlptracehttp.WithInsecure()) + } + exp, err := otlptracehttp.New(context.Background(), opts...) if err != nil { return fmt.Errorf("building tracing exporter: %w", err) } -- cgit v1.2.3