From 79ccd8fd8acd09f78385cda799e9049cbc59de0f Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Mon, 22 Nov 2021 14:40:23 +0100 Subject: Fix mentioned accounts visibility bug (#323) * update other tests * set test status to followers_only * add test dm * fix mentioned accounts not being added to relevantAccounts * add some visibility tests for statuses --- internal/timeline/get_test.go | 16 ++++++++-------- internal/timeline/index_test.go | 4 ++-- internal/timeline/manager_test.go | 10 +++++----- 3 files changed, 15 insertions(+), 15 deletions(-) (limited to 'internal/timeline') diff --git a/internal/timeline/get_test.go b/internal/timeline/get_test.go index 22b2c5be8..b05585cab 100644 --- a/internal/timeline/get_test.go +++ b/internal/timeline/get_test.go @@ -73,8 +73,8 @@ func (suite *GetTestSuite) TestGetDefault() { suite.FailNow(err.Error()) } - // we only have 13 statuses in the test suite - suite.Len(statuses, 13) + // we only have 14 statuses in the test suite + suite.Len(statuses, 14) // statuses should be sorted highest to lowest ID var highest string @@ -166,8 +166,8 @@ func (suite *GetTestSuite) TestGetMinID() { suite.FailNow(err.Error()) } - // we should only get 6 statuses back, since we asked for a min ID that excludes some of our entries - suite.Len(statuses, 6) + // we should only get 7 statuses back, since we asked for a min ID that excludes some of our entries + suite.Len(statuses, 7) // statuses should be sorted highest to lowest ID var highest string @@ -188,8 +188,8 @@ func (suite *GetTestSuite) TestGetSinceID() { suite.FailNow(err.Error()) } - // we should only get 6 statuses back, since we asked for a since ID that excludes some of our entries - suite.Len(statuses, 6) + // we should only get 7 statuses back, since we asked for a since ID that excludes some of our entries + suite.Len(statuses, 7) // statuses should be sorted highest to lowest ID var highest string @@ -210,8 +210,8 @@ func (suite *GetTestSuite) TestGetSinceIDPrepareNext() { suite.FailNow(err.Error()) } - // we should only get 6 statuses back, since we asked for a since ID that excludes some of our entries - suite.Len(statuses, 6) + // we should only get 7 statuses back, since we asked for a since ID that excludes some of our entries + suite.Len(statuses, 7) // statuses should be sorted highest to lowest ID var highest string diff --git a/internal/timeline/index_test.go b/internal/timeline/index_test.go index 681f7617b..0f3a1df4a 100644 --- a/internal/timeline/index_test.go +++ b/internal/timeline/index_test.go @@ -66,7 +66,7 @@ func (suite *IndexTestSuite) TestIndexBeforeLowID() { // the oldest indexed post should be the lowest one we have in our testrig postID, err := suite.timeline.OldestIndexedPostID(context.Background()) suite.NoError(err) - suite.Equal("01F8MHAMCHF6Y650WCRSCP4WMY", postID) + suite.Equal("01F8MHAYFKS4KMXF8K5Y1C0KRN", postID) indexLength := suite.timeline.PostIndexLength(context.Background()) suite.Equal(10, indexLength) @@ -95,7 +95,7 @@ func (suite *IndexTestSuite) TestIndexBehindHighID() { // the newest indexed post should be the highest one we have in our testrig postID, err := suite.timeline.NewestIndexedPostID(context.Background()) suite.NoError(err) - suite.Equal("01FF25D5Q0DH7CHD57CTRS6WK0", postID) + suite.Equal("01FN3VJGFH10KR7S2PB0GFJZYG", postID) // indexLength should be 10 because that's all this user has hometimelineable indexLength := suite.timeline.PostIndexLength(context.Background()) diff --git a/internal/timeline/manager_test.go b/internal/timeline/manager_test.go index 072761cd7..4d725e48d 100644 --- a/internal/timeline/manager_test.go +++ b/internal/timeline/manager_test.go @@ -67,9 +67,9 @@ func (suite *ManagerTestSuite) TestManagerIntegration() { err = suite.manager.PrepareXFromTop(context.Background(), testAccount.ID, 20) suite.NoError(err) - // local_account_1 can see 13 statuses out of the testrig statuses in its home timeline + // local_account_1 can see 14 statuses out of the testrig statuses in its home timeline indexedLen = suite.manager.GetIndexedLength(context.Background(), testAccount.ID) - suite.Equal(13, indexedLen) + suite.Equal(14, indexedLen) // oldest should now be set oldestIndexed, err = suite.manager.GetOldestIndexedID(context.Background(), testAccount.ID) @@ -79,7 +79,7 @@ func (suite *ManagerTestSuite) TestManagerIntegration() { // get hometimeline statuses, err := suite.manager.HomeTimeline(context.Background(), testAccount.ID, "", "", "", 20, false) suite.NoError(err) - suite.Len(statuses, 13) + suite.Len(statuses, 14) // now wipe the last status from all timelines, as though it had been deleted by the owner err = suite.manager.WipeStatusFromAllTimelines(context.Background(), "01F8MH75CBF9JFX4ZAD54N0W0R") @@ -87,7 +87,7 @@ func (suite *ManagerTestSuite) TestManagerIntegration() { // timeline should be shorter indexedLen = suite.manager.GetIndexedLength(context.Background(), testAccount.ID) - suite.Equal(12, indexedLen) + suite.Equal(13, indexedLen) // oldest should now be different oldestIndexed, err = suite.manager.GetOldestIndexedID(context.Background(), testAccount.ID) @@ -101,7 +101,7 @@ func (suite *ManagerTestSuite) TestManagerIntegration() { // timeline should be shorter indexedLen = suite.manager.GetIndexedLength(context.Background(), testAccount.ID) - suite.Equal(11, indexedLen) + suite.Equal(12, indexedLen) // oldest should now be different oldestIndexed, err = suite.manager.GetOldestIndexedID(context.Background(), testAccount.ID) -- cgit v1.2.3