From e52b314f65e661b7e832a65d884b2425f8a1afcf Mon Sep 17 00:00:00 2001 From: TwizzyDizzy Date: Mon, 3 Nov 2025 17:18:44 +0100 Subject: [bugfix] Fix invalid period parameter when generating the TOTP URL (#4536) # Description This MR removes the time unit `s` (for seconds) from the `period` parameter in the TOTP URL. closes #4535 ## Checklist Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]` If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want). - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [ ] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [ ] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [ ] I/we have added tests that cover new code. - [ ] I/we have run tests and they pass locally with the changes. - [ ] I/we have run `go fmt ./...` and `golangci-lint run`. Co-authored-by: gruf Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4536 Co-authored-by: TwizzyDizzy Co-committed-by: TwizzyDizzy --- internal/processing/user/twofactor.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'internal/processing') diff --git a/internal/processing/user/twofactor.go b/internal/processing/user/twofactor.go index 6fdd8898f..cbd986b23 100644 --- a/internal/processing/user/twofactor.go +++ b/internal/processing/user/twofactor.go @@ -132,8 +132,8 @@ func (p *Processor) TwoFactorQRCodeURIGet( RawQuery: encodeQuery(url.Values{ "secret": {user.TwoFactorSecret}, "issuer": {issuer}, - "period": {"30s"}, // 30s totp validity. - "digits": {"6"}, // 6-digit totp. + "period": {"30"}, // 30 seconds totp validity. + "digits": {"6"}, // 6-digit totp. "algorithm": {"SHA1"}, }), }, nil -- cgit v1.2.3