From 0f734a24100383171a866fccc194dea578141d74 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Fri, 2 Aug 2024 12:15:11 +0000 Subject: [chore] move PopulateAccountStats() nil check often performed into function itself (#3158) * move PopulateAccountStats() nil check often performed into function itself * fix test to take in mind we don't repopulate account stats if not-nil --- internal/processing/workers/util.go | 48 +++++++++++++------------------------ 1 file changed, 16 insertions(+), 32 deletions(-) (limited to 'internal/processing/workers/util.go') diff --git a/internal/processing/workers/util.go b/internal/processing/workers/util.go index 994242d37..7f6c259de 100644 --- a/internal/processing/workers/util.go +++ b/internal/processing/workers/util.go @@ -257,10 +257,8 @@ func (u *utils) incrementStatusesCount( defer unlock() // Populate stats. - if account.Stats == nil { - if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { - return gtserror.Newf("db error getting account stats: %w", err) - } + if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { + return gtserror.Newf("db error getting account stats: %w", err) } // Update stats by incrementing status @@ -288,10 +286,8 @@ func (u *utils) decrementStatusesCount( defer unlock() // Populate stats. - if account.Stats == nil { - if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { - return gtserror.Newf("db error getting account stats: %w", err) - } + if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { + return gtserror.Newf("db error getting account stats: %w", err) } // Update stats by decrementing @@ -322,10 +318,8 @@ func (u *utils) incrementFollowersCount( defer unlock() // Populate stats. - if account.Stats == nil { - if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { - return gtserror.Newf("db error getting account stats: %w", err) - } + if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { + return gtserror.Newf("db error getting account stats: %w", err) } // Update stats by incrementing followers @@ -351,10 +345,8 @@ func (u *utils) decrementFollowersCount( defer unlock() // Populate stats. - if account.Stats == nil { - if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { - return gtserror.Newf("db error getting account stats: %w", err) - } + if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { + return gtserror.Newf("db error getting account stats: %w", err) } // Update stats by decrementing @@ -385,10 +377,8 @@ func (u *utils) incrementFollowingCount( defer unlock() // Populate stats. - if account.Stats == nil { - if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { - return gtserror.Newf("db error getting account stats: %w", err) - } + if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { + return gtserror.Newf("db error getting account stats: %w", err) } // Update stats by incrementing @@ -414,10 +404,8 @@ func (u *utils) decrementFollowingCount( defer unlock() // Populate stats. - if account.Stats == nil { - if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { - return gtserror.Newf("db error getting account stats: %w", err) - } + if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { + return gtserror.Newf("db error getting account stats: %w", err) } // Update stats by decrementing @@ -448,10 +436,8 @@ func (u *utils) incrementFollowRequestsCount( defer unlock() // Populate stats. - if account.Stats == nil { - if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { - return gtserror.Newf("db error getting account stats: %w", err) - } + if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { + return gtserror.Newf("db error getting account stats: %w", err) } // Update stats by incrementing @@ -477,10 +463,8 @@ func (u *utils) decrementFollowRequestsCount( defer unlock() // Populate stats. - if account.Stats == nil { - if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { - return gtserror.Newf("db error getting account stats: %w", err) - } + if err := u.state.DB.PopulateAccountStats(ctx, account); err != nil { + return gtserror.Newf("db error getting account stats: %w", err) } // Update stats by decrementing -- cgit v1.2.3