From 61ffbba4d952bbd2df1a018c40d91da1dc62c8e1 Mon Sep 17 00:00:00 2001 From: tobi Date: Sun, 30 Nov 2025 14:40:37 +0100 Subject: [bugfix] Return unboosted status with reblogged=false (#4593) # Description > If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements. > > If this is a documentation change, please briefly describe what you've changed and why. Closes https://codeberg.org/superseriousbusiness/gotosocial/issues/4584 by setting reblogged=false on the returned status, even though side effects haven't processed yet (we can safely assume they will). ## Checklist Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]` If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want). - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [x] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4593 Co-authored-by: tobi Co-committed-by: tobi --- internal/processing/status/boost.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'internal/processing/status/boost.go') diff --git a/internal/processing/status/boost.go b/internal/processing/status/boost.go index 4a97706ab..d3fa87255 100644 --- a/internal/processing/status/boost.go +++ b/internal/processing/status/boost.go @@ -210,7 +210,15 @@ func (p *Processor) BoostRemove( }) } - return p.c.GetAPIStatus(ctx, requester, target) + // For client convenience, mark the status as unboosted + // even though side effects probably haven't completed yet. + unboostedStatus, errWithCode := p.c.GetAPIStatus(ctx, requester, target) + if errWithCode != nil { + return nil, errWithCode + } + unboostedStatus.Reblogged = false + + return unboostedStatus, nil } // StatusBoostedBy returns a slice of accounts that have boosted the given status, filtered according to privacy settings. -- cgit v1.3