From 996da6e0291b158093d917ca76933584f464d668 Mon Sep 17 00:00:00 2001 From: kim Date: Tue, 24 Jun 2025 17:24:34 +0200 Subject: [performance] filter model and database table improvements (#4277) - removes unnecessary fields / columns (created_at, updated_at) - replaces filter.context_* columns with singular filter.contexts bit field which should save both struct memory and database space - replaces filter.action string with integer enum type which should save both struct memory and database space - adds links from filter to filter_* tables with Filter{}.KeywordIDs and Filter{}.StatusIDs fields (this also means we now have those ID slices cached, which reduces some lookups) - removes account_id fields from filter_* tables, since there's a more direct connection between filter and filter_* tables, and filter.account_id already exists - refactors a bunch of the filter processor logic to save on code repetition, factor in the above changes, fix a few bugs with missed error returns and bring it more in-line with some of our newer code Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4277 Co-authored-by: kim Co-committed-by: kim --- internal/processing/search/util.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'internal/processing/search/util.go') diff --git a/internal/processing/search/util.go b/internal/processing/search/util.go index 97eb813db..b4568722d 100644 --- a/internal/processing/search/util.go +++ b/internal/processing/search/util.go @@ -21,7 +21,6 @@ import ( "context" apimodel "code.superseriousbusiness.org/gotosocial/internal/api/model" - statusfilter "code.superseriousbusiness.org/gotosocial/internal/filter/status" "code.superseriousbusiness.org/gotosocial/internal/gtserror" "code.superseriousbusiness.org/gotosocial/internal/gtsmodel" "code.superseriousbusiness.org/gotosocial/internal/log" @@ -114,7 +113,7 @@ func (p *Processor) packageStatuses( continue } - apiStatus, err := p.converter.StatusToAPIStatus(ctx, status, requestingAccount, statusfilter.FilterContextNone, nil) + apiStatus, err := p.converter.StatusToAPIStatus(ctx, status, requestingAccount, gtsmodel.FilterContextNone, nil) if err != nil { log.Debugf(ctx, "skipping status %s because it couldn't be converted to its api representation: %s", status.ID, err) continue -- cgit v1.2.3