From de6e3e5f2a8ea639d76e310a11cb9bc093fef3a9 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Tue, 28 Mar 2023 14:03:14 +0100 Subject: [performance] refactoring + add fave / follow / request / visibility caching (#1607) * refactor visibility checking, add caching for visibility * invalidate visibility cache items on account / status deletes * fix requester ID passed to visibility cache nil ptr * de-interface caches, fix home / public timeline caching + visibility * finish adding code comments for visibility filter * fix angry goconst linter warnings * actually finish adding filter visibility code comments for timeline functions * move home timeline status author check to after visibility * remove now-unused code * add more code comments * add TODO code comment, update printed cache start names * update printed cache names on stop * start adding separate follow(request) delete db functions, add specific visibility cache tests * add relationship type caching * fix getting local account follows / followed-bys, other small codebase improvements * simplify invalidation using cache hooks, add more GetAccountBy___() functions * fix boosting to return 404 if not boostable but no error (to not leak status ID) * remove dead code * improved placement of cache invalidation * update license headers * add example follow, follow-request config entries * add example visibility cache configuration to config file * use specific PutFollowRequest() instead of just Put() * add tests for all GetAccountBy() * add GetBlockBy() tests * update block to check primitive fields * update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests * fix copy-pasted code * update envparsing test * whitespace * fix bun struct tag * add license header to gtscontext * fix old license header * improved error creation to not use fmt.Errorf() when not needed * fix various rebase conflicts, fix account test * remove commented-out code, fix-up mention caching * fix mention select bun statement * ensure mention target account populated, pass in context to customrenderer logging * remove more uncommented code, fix typeutil test * add statusfave database model caching * add status fave cache configuration * add status fave cache example config * woops, catch missed error. nice catch linter! * add back testrig panic on nil db * update example configuration to match defaults, slight tweak to cache configuration defaults * update envparsing test with new defaults * fetch followingget to use the follow target account * use accounnt.IsLocal() instead of empty domain check * use constants for the cache visibility type check * use bun.In() for notification type restriction in db query * include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable()) * use bun query building for nested select statements to ensure working with postgres * update public timeline future status checks to match visibility filter * same as previous, for home timeline * update public timeline tests to dynamically check for appropriate statuses * migrate accounts to allow unique constraint on public_key * provide minimal account with publicKey --------- Signed-off-by: kim Co-authored-by: tsmethurst --- internal/processing/processor.go | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) (limited to 'internal/processing/processor.go') diff --git a/internal/processing/processor.go b/internal/processing/processor.go index 3e3854f69..a61a57f88 100644 --- a/internal/processing/processor.go +++ b/internal/processing/processor.go @@ -47,8 +47,8 @@ type Processor struct { mediaManager mm.Manager statusTimelines timeline.Manager state *state.State - filter visibility.Filter emailSender email.Sender + filter *visibility.Filter /* SUB-PROCESSORS @@ -107,7 +107,7 @@ func NewProcessor( ) *Processor { parseMentionFunc := GetParseMentionFunc(state.DB, federator) - filter := visibility.NewFilter(state.DB) + filter := visibility.NewFilter(state) processor := &Processor{ federator: federator, @@ -126,12 +126,12 @@ func NewProcessor( } // sub processors - processor.account = account.New(state, tc, mediaManager, oauthServer, federator, parseMentionFunc) + processor.account = account.New(state, tc, mediaManager, oauthServer, federator, filter, parseMentionFunc) processor.admin = admin.New(state, tc, mediaManager, federator.TransportController(), emailSender) - processor.fedi = fedi.New(state, tc, federator) + processor.fedi = fedi.New(state, tc, federator, filter) processor.media = media.New(state, tc, mediaManager, federator.TransportController()) processor.report = report.New(state, tc) - processor.status = status.New(state, tc, parseMentionFunc) + processor.status = status.New(state, tc, filter, parseMentionFunc) processor.stream = stream.New(state, oauthServer) processor.user = user.New(state, emailSender) @@ -139,22 +139,24 @@ func NewProcessor( } func (p *Processor) EnqueueClientAPI(ctx context.Context, msgs ...messages.FromClientAPI) { - log.Trace(ctx, "enqueuing client API") + log.Trace(ctx, "enqueuing") _ = p.state.Workers.ClientAPI.MustEnqueueCtx(ctx, func(ctx context.Context) { for _, msg := range msgs { + log.Trace(ctx, "processing: %+v", msg) if err := p.ProcessFromClientAPI(ctx, msg); err != nil { - log.WithContext(ctx).WithField("msg", msg).Errorf("error processing client API message: %v", err) + log.Errorf(ctx, "error processing client API message: %v", err) } } }) } func (p *Processor) EnqueueFederator(ctx context.Context, msgs ...messages.FromFederator) { - log.Trace(ctx, "enqueuing federator") + log.Trace(ctx, "enqueuing") _ = p.state.Workers.Federator.MustEnqueueCtx(ctx, func(ctx context.Context) { for _, msg := range msgs { + log.Trace(ctx, "processing: %+v", msg) if err := p.ProcessFromFederator(ctx, msg); err != nil { - log.WithContext(ctx).WithField("msg", msg).Errorf("error processing federator message: %v", err) + log.Errorf(ctx, "error processing federator message: %v", err) } } }) -- cgit v1.2.3