From a314d2b539804a31e602774196676e2d0089b8dc Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Mon, 19 Feb 2024 04:48:20 +0100 Subject: [bugfix] Refactor parse mention, fix local mention bug (#2657) * [bugfix] Refactor parse mention, fix local mention bug * originAccount -> originAcct --- internal/processing/parsemention_test.go | 108 +++++++++++++++++++++++++++++++ 1 file changed, 108 insertions(+) create mode 100644 internal/processing/parsemention_test.go (limited to 'internal/processing/parsemention_test.go') diff --git a/internal/processing/parsemention_test.go b/internal/processing/parsemention_test.go new file mode 100644 index 000000000..f97133969 --- /dev/null +++ b/internal/processing/parsemention_test.go @@ -0,0 +1,108 @@ +// GoToSocial +// Copyright (C) GoToSocial Authors admin@gotosocial.org +// SPDX-License-Identifier: AGPL-3.0-or-later +// +// This program is free software: you can redistribute it and/or modify +// it under the terms of the GNU Affero General Public License as published by +// the Free Software Foundation, either version 3 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU Affero General Public License for more details. +// +// You should have received a copy of the GNU Affero General Public License +// along with this program. If not, see . + +package processing_test + +import ( + "context" + "errors" + "testing" + + "github.com/stretchr/testify/suite" + "github.com/superseriousbusiness/gotosocial/internal/gtsmodel" + "github.com/superseriousbusiness/gotosocial/internal/id" + "github.com/superseriousbusiness/gotosocial/internal/processing" +) + +type ParseMentionTestSuite struct { + ProcessingStandardTestSuite +} + +func (suite *ParseMentionTestSuite) TestParseMentionFunc() { + var ( + ctx = context.Background() + parseMention = processing.GetParseMentionFunc(&suite.state, suite.federator) + originAcctID = suite.testAccounts["local_account_1"].ID + statusID = id.NewULID() + ) + + type testStruct struct { + namestring string + expectedTargetAcct *gtsmodel.Account + err error + } + + for i, test := range []testStruct{ + { + namestring: "@1happyturtle", + expectedTargetAcct: suite.testAccounts["local_account_2"], + }, + { + namestring: "@1happyturtle@localhost:8080", + expectedTargetAcct: suite.testAccounts["local_account_2"], + }, + { + namestring: "@foss_satan@fossbros-anonymous.io", + expectedTargetAcct: suite.testAccounts["remote_account_1"], + }, + { + namestring: "@foss_satan", + err: errors.New("db error getting mention local target account foss_satan: sql: no rows in result set"), + }, + { + namestring: "@foss_satan@aaaaaaaaaaaaaaaaaaa.example.org", + err: errors.New("error fetching mention remote target account: enrichAccount: error webfingering account: fingerRemoteAccount: error webfingering @foss_satan@aaaaaaaaaaaaaaaaaaa.example.org: failed to discover webfinger URL fallback for: aaaaaaaaaaaaaaaaaaa.example.org through host-meta: GET request for https://aaaaaaaaaaaaaaaaaaa.example.org/.well-known/host-meta failed: "), + }, + { + namestring: "pee pee poo poo", + err: errors.New("error extracting mention target: couldn't match namestring pee pee poo poo"), + }, + } { + mention, err := parseMention(ctx, test.namestring, originAcctID, statusID) + if test.err != nil { + suite.EqualError(err, test.err.Error()) + continue + } + + if err != nil { + suite.Fail(err.Error()) + continue + } + + if mention.OriginAccount == nil { + suite.Failf("nil origin account", "test %d, namestring %s", i+1, test.namestring) + continue + } + + if mention.TargetAccount == nil { + suite.Failf("nil target account", "test %d, namestring %s", i+1, test.namestring) + continue + } + + suite.NotEmpty(mention.ID) + suite.Equal(originAcctID, mention.OriginAccountID) + suite.Equal(originAcctID, mention.OriginAccount.ID) + suite.Equal(test.expectedTargetAcct.ID, mention.TargetAccountID) + suite.Equal(test.expectedTargetAcct.ID, mention.TargetAccount.ID) + suite.Equal(test.expectedTargetAcct.URI, mention.TargetAccountURI) + suite.Equal(test.expectedTargetAcct.URL, mention.TargetAccountURL) + } +} + +func TestParseMentionTestSuite(t *testing.T) { + suite.Run(t, &ParseMentionTestSuite{}) +} -- cgit v1.2.3