From 29d481d76912a8b0de0eebc41e2d8bed5b17c535 Mon Sep 17 00:00:00 2001 From: nicole mikołajczyk Date: Thu, 19 Jun 2025 10:21:03 +0200 Subject: [bugfix] delete interaction requests when deleting account (#4278) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: nicole mikołajczyk # Description I recently noticed that pending interaction requests don't disappear on domain suspension. ## Checklist - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [ ] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [ ] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4278 Co-authored-by: nicole mikołajczyk Co-committed-by: nicole mikołajczyk --- internal/processing/account/delete.go | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'internal/processing/account') diff --git a/internal/processing/account/delete.go b/internal/processing/account/delete.go index 682da3681..f812909c5 100644 --- a/internal/processing/account/delete.go +++ b/internal/processing/account/delete.go @@ -478,6 +478,12 @@ func (p *Processor) deleteAccountPeripheral( err != nil && !errors.Is(err, db.ErrNoEntries) { log.Errorf("error deleting poll votes by account: %v", err) } + + // Delete all interaction requests from given account, local and remote. + if err := p.state.DB.DeleteInteractionRequestsByInteractingAccountID(ctx, account.ID); // nocollapse + err != nil && !errors.Is(err, db.ErrNoEntries) { + log.Errorf("error deleting interaction requests by account: %v", err) + } } // processSideEffect will process the given side effect details, -- cgit v1.2.3