From 0f734a24100383171a866fccc194dea578141d74 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Fri, 2 Aug 2024 12:15:11 +0000 Subject: [chore] move PopulateAccountStats() nil check often performed into function itself (#3158) * move PopulateAccountStats() nil check often performed into function itself * fix test to take in mind we don't repopulate account stats if not-nil --- internal/processing/account/rss.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'internal/processing/account/rss.go') diff --git a/internal/processing/account/rss.go b/internal/processing/account/rss.go index cbbb4875b..60f93b012 100644 --- a/internal/processing/account/rss.go +++ b/internal/processing/account/rss.go @@ -70,11 +70,9 @@ func (p *Processor) GetRSSFeedForUsername(ctx context.Context, username string) } // Ensure account stats populated. - if account.Stats == nil { - if err := p.state.DB.PopulateAccountStats(ctx, account); err != nil { - err = gtserror.Newf("db error getting account stats %s: %w", username, err) - return nil, never, gtserror.NewErrorInternalError(err) - } + if err := p.state.DB.PopulateAccountStats(ctx, account); err != nil { + err = gtserror.Newf("db error getting account stats %s: %w", username, err) + return nil, never, gtserror.NewErrorInternalError(err) } // LastModified time is needed by callers to check freshness for cacheing. -- cgit v1.2.3