From 23fc70f4e68730b7eec91d58dac54ec00099ed8d Mon Sep 17 00:00:00 2001
From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com>
Date: Thu, 5 Dec 2024 13:35:07 +0000
Subject: [feature] add support for receiving federated status edits (#3597)

* add support for extracting Updated field from Statusable implementers

* add support for status edits in the database, and update status dereferencer to handle them

* remove unused AdditionalInfo{}.CreatedAt

* remove unused AdditionalEmojiInfo{}.CreatedAt

* update new mention creation to use status.UpdatedAt

* remove mention.UpdatedAt, fixes related to NewULIDFromTime() change

* add migration to remove Mention{}.UpdatedAt field

* add migration to add the StatusEdit{} table

* start adding tests, add delete function for status edits

* add more of status edit migrations, fill in more of the necessary edit delete functionality

* remove unused function

* allow generating gotosocial compatible ulid via CLI with `go run ./cmd/gen-ulid`

* add StatusEdit{} test models

* fix new statusedits sql

* use model instead of table name

* actually remove the Mention.UpdatedAt field...

* fix tests now new models are added, add more status edit DB tests

* fix panic wording

* add test for deleting status edits

* don't automatically set `updated_at` field on updated statuses

* flesh out more of the dereferencer status edit tests, ensure updated at field set on outgoing AS statuses

* remove media_attachments.updated_at column

* fix up more tests, further complete the dereferencer status edit tests

* update more status serialization tests not expecting 'updated' AS property

* gah!! json serialization tests!!

* undo some gtscontext wrapping changes

* more serialization test fixing :smiling_face_with_tear:

* more test fixing, ensure the edit.status_id field is actually set :facepalm:

* fix status edit test

* grrr linter

* add edited_at field to apimodel status

* remove the choice of paging on the timeline public filtered test (otherwise it needs updating every time you add statuses ...)

* ensure that status.updated_at always fits chronologically

* fix more serialization tests ...

* add more code comments

* fix envparsing

* update swagger file

* properly handle media description changes during status edits

* slight formatting tweak

* code comment
---
 internal/media/manager.go      | 7 -------
 internal/media/manager_test.go | 1 -
 internal/media/types.go        | 9 ---------
 3 files changed, 17 deletions(-)

(limited to 'internal/media')

diff --git a/internal/media/manager.go b/internal/media/manager.go
index 2807848bd..6aa13c17b 100644
--- a/internal/media/manager.go
+++ b/internal/media/manager.go
@@ -118,15 +118,11 @@ func (m *Manager) CreateMedia(
 		Header:     util.Ptr(false),
 		Cached:     util.Ptr(false),
 		CreatedAt:  now,
-		UpdatedAt:  now,
 	}
 
 	// Check if we were provided additional info
 	// to add to the attachment, and overwrite
 	// some of the attachment fields if so.
-	if info.CreatedAt != nil {
-		attachment.CreatedAt = *info.CreatedAt
-	}
 	if info.StatusID != nil {
 		attachment.StatusID = *info.StatusID
 	}
@@ -372,9 +368,6 @@ func (m *Manager) createOrUpdateEmoji(
 	if info.URI != nil {
 		emoji.URI = *info.URI
 	}
-	if info.CreatedAt != nil {
-		emoji.CreatedAt = *info.CreatedAt
-	}
 	if info.Domain != nil {
 		emoji.Domain = *info.Domain
 	}
diff --git a/internal/media/manager_test.go b/internal/media/manager_test.go
index e175369f5..5b6882100 100644
--- a/internal/media/manager_test.go
+++ b/internal/media/manager_test.go
@@ -109,7 +109,6 @@ func (suite *ManagerTestSuite) TestEmojiProcessRefresh() {
 		emojiToUpdate,
 		data,
 		media.AdditionalEmojiInfo{
-			CreatedAt:      &emojiToUpdate.CreatedAt,
 			Domain:         &emojiToUpdate.Domain,
 			ImageRemoteURL: &newImageRemoteURL,
 		},
diff --git a/internal/media/types.go b/internal/media/types.go
index 9631a15bd..827752941 100644
--- a/internal/media/types.go
+++ b/internal/media/types.go
@@ -20,7 +20,6 @@ package media
 import (
 	"context"
 	"io"
-	"time"
 )
 
 type Size string
@@ -44,10 +43,6 @@ const (
 // should be added to attachment when processing a piece of media.
 type AdditionalMediaInfo struct {
 
-	// Time that this media was
-	// created; defaults to time.Now().
-	CreatedAt *time.Time
-
 	// ID of the status to which this
 	// media is attached; defaults to "".
 	StatusID *string
@@ -93,10 +88,6 @@ type AdditionalEmojiInfo struct {
 	// this remote emoji.
 	URI *string
 
-	// Time that this emoji was
-	// created; defaults to time.Now().
-	CreatedAt *time.Time
-
 	// Domain the emoji originated from. Blank
 	// for this instance's domain. Defaults to "".
 	Domain *string
-- 
cgit v1.3