From 72ba5666a6ffd06ccdfd2db8dacc47de7f777a4c Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Wed, 17 Jul 2024 15:26:33 +0000 Subject: [chore] media pipeline improvements (#3110) * don't set emoji / media image paths on failed download, migrate FileType from string to integer * fix incorrect uses of util.PtrOr, fix returned frontend media * fix migration not setting arguments correctly in where clause * fix not providing default with not null column * whoops * ensure a default gets set for media attachment file type * remove the exclusive flag from writing files in disk storage * rename PtrOr -> PtrOrZero, and rename PtrValueOr -> PtrOrValue to match * slight wording changes * use singular / plural word forms (no parentheses), is better for screen readers * update testmodels with unknown media type to have unset file details, update attachment focus handling converting to frontend, update tests * store first instance in ffmpeg wasm pool, fill remaining with closed instances --- internal/media/manager_test.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'internal/media/manager_test.go') diff --git a/internal/media/manager_test.go b/internal/media/manager_test.go index 24e0ddd1e..c908b2994 100644 --- a/internal/media/manager_test.go +++ b/internal/media/manager_test.go @@ -358,11 +358,10 @@ func (suite *ManagerTestSuite) TestPDFProcess() { suite.Equal(processing.ID(), attachment.ID) suite.Equal(accountID, attachment.AccountID) - // file meta should be correctly derived from the image suite.Zero(attachment.FileMeta) - suite.Equal("application/octet-stream", attachment.File.ContentType) - suite.Equal("image/jpeg", attachment.Thumbnail.ContentType) - suite.Empty(attachment.Blurhash) + suite.Zero(attachment.File.ContentType) + suite.Zero(attachment.Thumbnail.ContentType) + suite.Zero(attachment.Blurhash) // now make sure the attachment is in the database dbAttachment, err := suite.db.GetAttachmentByID(ctx, attachment.ID) @@ -376,7 +375,6 @@ func (suite *ManagerTestSuite) TestPDFProcess() { stored, err := suite.storage.Has(ctx, attachment.File.Path) suite.NoError(err) suite.False(stored) - stored, err = suite.storage.Has(ctx, attachment.Thumbnail.Path) suite.NoError(err) suite.False(stored) -- cgit v1.2.3