From e3dfd8889315af38c4eef1eb4247dc07a51899c7 Mon Sep 17 00:00:00 2001 From: kim Date: Tue, 29 Jul 2025 09:23:20 +0200 Subject: [performance] bump codeberg.org/gruf/go-kv to v2 (#4341) updates our codeberg.org/gruf/go-kv log key-value formatting library to latest version, which comes with some maaaaaaajor speed boosts in the form of: - very minimal reflect.Value{} usage - caching prepared formatting functions per type ~~still a work-in-progress until i make a release tag on the go-kv repository, which itself is waiting on published benchmark results in the README and finishing writing some code comments~~ benchmarks so far show this to be ~3x faster than the "fmt" stdlib package on average, when run across a wide variety (106 different types) of test cases, while still creating more visually friendly log output and actually recursing down nested struct ptrs Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4341 Co-authored-by: kim Co-committed-by: kim --- internal/log/entry.go | 2 +- internal/log/format.go | 29 ----------------------------- internal/log/log.go | 2 +- 3 files changed, 2 insertions(+), 31 deletions(-) delete mode 100644 internal/log/format.go (limited to 'internal/log') diff --git a/internal/log/entry.go b/internal/log/entry.go index 52e90caed..48059c3bf 100644 --- a/internal/log/entry.go +++ b/internal/log/entry.go @@ -21,7 +21,7 @@ import ( "context" "fmt" - "codeberg.org/gruf/go-kv" + "codeberg.org/gruf/go-kv/v2" ) type Entry struct { diff --git a/internal/log/format.go b/internal/log/format.go deleted file mode 100644 index e7468ed21..000000000 --- a/internal/log/format.go +++ /dev/null @@ -1,29 +0,0 @@ -// GoToSocial -// Copyright (C) GoToSocial Authors admin@gotosocial.org -// SPDX-License-Identifier: AGPL-3.0-or-later -// -// This program is free software: you can redistribute it and/or modify -// it under the terms of the GNU Affero General Public License as published by -// the Free Software Foundation, either version 3 of the License, or -// (at your option) any later version. -// -// This program is distributed in the hope that it will be useful, -// but WITHOUT ANY WARRANTY; without even the implied warranty of -// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -// GNU Affero General Public License for more details. -// -// You should have received a copy of the GNU Affero General Public License -// along with this program. If not, see . - -package log - -import "codeberg.org/gruf/go-kv/format" - -// VarDump returns a serialized, useful log / error output of given variable. -func VarDump(a any) string { - buf := getBuf() - format.Appendf(buf, "{:v}", a) - s := string(buf.B) - putBuf(buf) - return s -} diff --git a/internal/log/log.go b/internal/log/log.go index bf2259b50..afb1bcdb8 100644 --- a/internal/log/log.go +++ b/internal/log/log.go @@ -26,7 +26,7 @@ import ( "time" "code.superseriousbusiness.org/gotosocial/internal/util/xslices" - "codeberg.org/gruf/go-kv" + "codeberg.org/gruf/go-kv/v2" ) var ( -- cgit v1.2.3