From 098dbe6ff4f59652181c8e0e3873fbfcf0e65ea3 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Tue, 19 Jul 2022 09:47:55 +0100 Subject: [chore] use our own logging implementation (#716) * first commit Signed-off-by: kim * replace logging with our own log library Signed-off-by: kim * fix imports Signed-off-by: kim * fix log imports Signed-off-by: kim * add license text Signed-off-by: kim * fix package import cycle between config and log package Signed-off-by: kim * fix empty kv.Fields{} being passed to WithFields() Signed-off-by: kim * fix uses of log.WithFields() with whitespace issues and empty slices Signed-off-by: kim * *linter related grumbling* Signed-off-by: kim * gofmt the codebase! also fix more log.WithFields() formatting issues Signed-off-by: kim * update testrig code to match new changes Signed-off-by: kim * fix error wrapping in non fmt.Errorf function Signed-off-by: kim * add benchmarking of log.Caller() vs non-cached Signed-off-by: kim * fix syslog tests, add standard build tags to test runner to ensure consistency Signed-off-by: kim * make syslog tests more robust Signed-off-by: kim * fix caller depth arithmatic (is that how you spell it?) Signed-off-by: kim * update to use unkeyed fields in kv.Field{} instances Signed-off-by: kim * update go-kv library Signed-off-by: kim * update libraries list Signed-off-by: kim * fuck you linter get nerfed Signed-off-by: kim Co-authored-by: tobi <31960611+tsmethurst@users.noreply.github.com> --- internal/log/caller_test.go | 54 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 internal/log/caller_test.go (limited to 'internal/log/caller_test.go') diff --git a/internal/log/caller_test.go b/internal/log/caller_test.go new file mode 100644 index 000000000..59bf342d1 --- /dev/null +++ b/internal/log/caller_test.go @@ -0,0 +1,54 @@ +package log_test + +import ( + "runtime" + "strings" + "testing" + + "codeberg.org/gruf/go-atomics" + "github.com/superseriousbusiness/gotosocial/internal/log" +) + +// noopt exists to prevent certain optimisations during benching. +var noopt = atomics.NewString() + +func BenchmarkCaller(b *testing.B) { + b.RunParallel(func(pb *testing.PB) { + for pb.Next() { + name := log.Caller(2) + noopt.Store(name) + } + }) +} + +func BenchmarkCallerNoCache(b *testing.B) { + b.RunParallel(func(pb *testing.PB) { + for pb.Next() { + var rpc [1]uintptr + + // Fetch pcs of callers + n := runtime.Callers(2, rpc[:]) + + if n > 0 { + // Fetch frame info for caller pc + frame, _ := runtime.CallersFrames(rpc[:]).Next() + + if frame.PC != 0 { + name := frame.Function + + // Drop all but the package name and function name, no mod path + if idx := strings.LastIndex(name, "/"); idx >= 0 { + name = name[idx+1:] + } + + // Drop any generic type parameter markers + if idx := strings.Index(name, "[...]"); idx >= 0 { + name = name[:idx] + name[idx+5:] + } + + noopt.Store(name) + } + } + } + }) +} -- cgit v1.2.3