From 8effc77788a201efe87636c94e16436da26b5199 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Tue, 17 Sep 2024 19:35:47 +0000 Subject: [chore] improved federatingdb logging in cases of unknown iri / types (#3313) * improved federatingdb logging in cases of unknown iri / types, add new log methods * whoops; forgot to wrap log argument in serialize{} ! * use debug instead of warn level * switch last entry to Debug --- internal/federation/federatingdb/update.go | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) (limited to 'internal/federation/federatingdb/update.go') diff --git a/internal/federation/federatingdb/update.go b/internal/federation/federatingdb/update.go index 16ecf3443..a2a9777d1 100644 --- a/internal/federation/federatingdb/update.go +++ b/internal/federation/federatingdb/update.go @@ -21,7 +21,6 @@ import ( "context" "errors" - "codeberg.org/gruf/go-logger/v2/level" "github.com/superseriousbusiness/activity/streams/vocab" "github.com/superseriousbusiness/gotosocial/internal/ap" "github.com/superseriousbusiness/gotosocial/internal/config" @@ -42,16 +41,7 @@ import ( // // The library makes this call only after acquiring a lock first. func (f *federatingDB) Update(ctx context.Context, asType vocab.Type) error { - l := log.WithContext(ctx) - - if log.Level() >= level.DEBUG { - i, err := marshalItem(asType) - if err != nil { - return err - } - l = l.WithField("update", i) - l.Debug("entering Update") - } + log.DebugKV(ctx, "update", serialize{asType}) activityContext := getActivityContext(ctx) if activityContext.internal { @@ -69,6 +59,7 @@ func (f *federatingDB) Update(ctx context.Context, asType vocab.Type) error { return f.updateStatusable(ctx, receivingAcct, requestingAcct, statusable) } + log.Debugf(ctx, "unhandled object type: %T", asType) return nil } -- cgit v1.2.3