From c9d893fec18fbb638eda1ee03776ae34c562f39b Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Wed, 23 Nov 2022 22:40:07 +0100 Subject: [feature/performance] Fail fast when doing remote transport calls inside incoming request contexts (#1119) * [feature/performance] Fail fast when doing remote transport calls inside incoming request contexts * [chore] Reduce outgoing request timeout to 15s * log error messages when fastfailing * use context.Value() instead of wrapped context, wrap error with fastfail instead of extra log entry * add fast-fail context key test Signed-off-by: kim Co-authored-by: kim --- internal/federation/dereferencing/account.go | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'internal/federation/dereferencing') diff --git a/internal/federation/dereferencing/account.go b/internal/federation/dereferencing/account.go index 6e107a11d..e351cd2fd 100644 --- a/internal/federation/dereferencing/account.go +++ b/internal/federation/dereferencing/account.go @@ -87,6 +87,11 @@ type GetRemoteAccountParams struct { // // If a local account is passed into this function for whatever reason (hey, it happens!), then it // will be returned from the database without making any remote calls. +// +// Even if a fastfail context is used, and something goes wrong, an account might still be returned instead +// of an error, if we already had the account in our database (in other words, if we just needed to try +// fingering/refreshing the account again). The rationale for this is that it's more useful to be able +// to provide *something* to the caller, even if that something is not necessarily 100% up to date. func (d *deref) GetRemoteAccount(ctx context.Context, params GetRemoteAccountParams) (foundAccount *gtsmodel.Account, err error) { /* In this function we want to retrieve a gtsmodel representation of a remote account, with its proper -- cgit v1.2.3