From c2738474d5f4bcdd83bdc09c372f27fe677201ab Mon Sep 17 00:00:00 2001 From: Julian Date: Sat, 22 Jun 2024 23:36:30 +0200 Subject: [bugfix] add Date and Message-ID headers for email (#3031) * [bugfix] add Date and Message-ID headers for email This should make spam filters more happy, as most of them grant some negative score for not having those headers. Also the Date is convenient for the user receiving the mail. * make golangci-lint happy --- internal/email/noopsender.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'internal/email/noopsender.go') diff --git a/internal/email/noopsender.go b/internal/email/noopsender.go index 20d7df2eb..bd9b1206e 100644 --- a/internal/email/noopsender.go +++ b/internal/email/noopsender.go @@ -31,6 +31,7 @@ import ( // Passing a nil function is also acceptable, in which case the send functions will just return nil. func NewNoopSender(sendCallback func(toAddress string, message string)) (Sender, error) { templateBaseDir := config.GetWebTemplateBaseDir() + msgIDHost := config.GetHost() t, err := loadTemplates(templateBaseDir) if err != nil { @@ -39,12 +40,14 @@ func NewNoopSender(sendCallback func(toAddress string, message string)) (Sender, return &noopSender{ sendCallback: sendCallback, + msgIDHost: msgIDHost, template: t, }, nil } type noopSender struct { sendCallback func(toAddress string, message string) + msgIDHost string template *template.Template } @@ -86,7 +89,7 @@ func (s *noopSender) sendTemplate(template string, subject string, data any, toA return err } - msg, err := assembleMessage(subject, buf.String(), "test@example.org", toAddresses...) + msg, err := assembleMessage(subject, buf.String(), "test@example.org", s.msgIDHost, toAddresses...) if err != nil { return err } -- cgit v1.2.3