From d98a48b446edb5bf2c3b79bdfd382d505a08a6fc Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Fri, 18 Nov 2022 17:23:14 +0100 Subject: [performance] don't use relations to select notification structs, use caches instead (#1072) --- internal/db/bundb/notification.go | 3 --- internal/db/bundb/notification_test.go | 3 --- 2 files changed, 6 deletions(-) (limited to 'internal/db') diff --git a/internal/db/bundb/notification.go b/internal/db/bundb/notification.go index 1874f81ea..6a8fab464 100644 --- a/internal/db/bundb/notification.go +++ b/internal/db/bundb/notification.go @@ -55,9 +55,6 @@ func (n *notificationDB) GetNotification(ctx context.Context, id string) (*gtsmo q := n.conn.NewSelect(). Model(¬if). - Relation("OriginAccount"). - Relation("TargetAccount"). - Relation("Status"). Where("? = ?", bun.Ident("notification.id"), id) if err := q.Scan(ctx); err != nil { return nil, n.conn.ProcessError(err) diff --git a/internal/db/bundb/notification_test.go b/internal/db/bundb/notification_test.go index 704d3373b..cd5022951 100644 --- a/internal/db/bundb/notification_test.go +++ b/internal/db/bundb/notification_test.go @@ -113,9 +113,6 @@ func (suite *NotificationTestSuite) TestGetNotificationsWithoutSpam() { suite.NotNil(notifications) for _, n := range notifications { suite.Equal(testAccount.ID, n.TargetAccountID) - suite.NotNil(n.OriginAccount) - suite.NotNil(n.TargetAccount) - suite.NotNil(n.Status) } } -- cgit v1.2.3