From 5f3e0957179eddd088e82b8f8f493164cbc9ce37 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Tue, 25 Jul 2023 09:34:05 +0100 Subject: [performance] retry db queries on busy errors (#2025) * catch SQLITE_BUSY errors, wrap bun.DB to use our own busy retrier, remove unnecessary db.Error type Signed-off-by: kim * remove dead code Signed-off-by: kim * remove more dead code, add missing error arguments Signed-off-by: kim * update sqlite to use maxOpenConns() Signed-off-by: kim * add uncommitted changes Signed-off-by: kim * use direct calls-through for the ConnIface to make sure we don't double query hook Signed-off-by: kim * expose underlying bun.DB better Signed-off-by: kim * retry on the correct busy error Signed-off-by: kim * use longer possible maxRetries for db retry-backoff Signed-off-by: kim * remove the note regarding max-open-conns only applying to postgres Signed-off-by: kim * improved code commenting Signed-off-by: kim * remove unnecessary infof call (just use info) Signed-off-by: kim * rename DBConn to WrappedDB to better follow sql package name conventions Signed-off-by: kim * update test error string checks Signed-off-by: kim * shush linter Signed-off-by: kim * update backoff logic to be more transparent Signed-off-by: kim --------- Signed-off-by: kim --- internal/db/user.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'internal/db/user.go') diff --git a/internal/db/user.go b/internal/db/user.go index 15165d0be..9df672837 100644 --- a/internal/db/user.go +++ b/internal/db/user.go @@ -26,21 +26,21 @@ import ( // User contains functions related to user getting/setting/creation. type User interface { // GetAllUsers returns all local user accounts, or an error if something goes wrong. - GetAllUsers(ctx context.Context) ([]*gtsmodel.User, Error) + GetAllUsers(ctx context.Context) ([]*gtsmodel.User, error) // GetUserByID returns one user with the given ID, or an error if something goes wrong. - GetUserByID(ctx context.Context, id string) (*gtsmodel.User, Error) + GetUserByID(ctx context.Context, id string) (*gtsmodel.User, error) // GetUserByAccountID returns one user by its account ID, or an error if something goes wrong. - GetUserByAccountID(ctx context.Context, accountID string) (*gtsmodel.User, Error) + GetUserByAccountID(ctx context.Context, accountID string) (*gtsmodel.User, error) // GetUserByID returns one user with the given email address, or an error if something goes wrong. - GetUserByEmailAddress(ctx context.Context, emailAddress string) (*gtsmodel.User, Error) + GetUserByEmailAddress(ctx context.Context, emailAddress string) (*gtsmodel.User, error) // GetUserByExternalID returns one user with the given external id, or an error if something goes wrong. - GetUserByExternalID(ctx context.Context, id string) (*gtsmodel.User, Error) + GetUserByExternalID(ctx context.Context, id string) (*gtsmodel.User, error) // GetUserByConfirmationToken returns one user by its confirmation token, or an error if something goes wrong. - GetUserByConfirmationToken(ctx context.Context, confirmationToken string) (*gtsmodel.User, Error) + GetUserByConfirmationToken(ctx context.Context, confirmationToken string) (*gtsmodel.User, error) // PutUser will attempt to place user in the database - PutUser(ctx context.Context, user *gtsmodel.User) Error + PutUser(ctx context.Context, user *gtsmodel.User) error // UpdateUser updates one user by its primary key, updating either only the specified columns, or all of them. - UpdateUser(ctx context.Context, user *gtsmodel.User, columns ...string) Error + UpdateUser(ctx context.Context, user *gtsmodel.User, columns ...string) error // DeleteUserByID deletes one user by its ID. - DeleteUserByID(ctx context.Context, userID string) Error + DeleteUserByID(ctx context.Context, userID string) error } -- cgit v1.2.3