From 84279f6a6a0201c90a6747fe8b82c38d5b4e49e2 Mon Sep 17 00:00:00 2001
From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com>
Date: Mon, 16 Sep 2024 16:46:09 +0000
Subject: [performance] cache more database calls, reduce required database
 calls overall (#3290)

* improvements to caching for lists and relationship to accounts / follows

* fix nil panic in AddToList()

* ensure list related caches are correctly invalidated

* ensure returned ID lists are ordered correctly

* bump go-structr to v0.8.9 (returns early if zero uncached keys to be loaded)

* remove zero checks in uncached key load functions (go-structr now handles this)

* fix issues after rebase on upstream/main

* update the expected return order of CSV exports (since list entries are now down by entry creation date)

* rename some funcs, allow deleting list entries for multiple follow IDs at a time, fix up more tests

* use returning statements on delete to get cache invalidation info

* fixes to recent database delete changes

* fix broken list entries delete sql

* remove unused db function

* update remainder of delete functions to behave in similar way, some other small tweaks

* fix delete user sql, allow returning on err no entries

* uncomment + fix list database tests

* update remaining list tests

* update envparsing test

* add comments to each specific key being invalidated

* add more cache invalidation explanatory comments

* whoops; actually delete poll votes from database in the DeletePollByID() func

* remove added but-commented-out field

* improved comment regarding paging being disabled

* make cache invalidation comments match what's actually happening

* fix up delete query comments to match what is happening

* rename function to read a bit better

* don't use ErrNoEntries on delete when not needed (it's only needed for a RETURNING call)

* update function name in test

* move list exclusivity check to AFTER eligibility check. use log.Panic() instead of panic()

* use the poll_id column in poll_votes for selecting votes in poll ID

* fix function name
---
 internal/db/poll.go | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

(limited to 'internal/db/poll.go')

diff --git a/internal/db/poll.go b/internal/db/poll.go
index ac0229855..88de6bfcd 100644
--- a/internal/db/poll.go
+++ b/internal/db/poll.go
@@ -39,7 +39,8 @@ type Poll interface {
 	// UpdatePoll updates the Poll in the database, only on selected columns if provided (else, all).
 	UpdatePoll(ctx context.Context, poll *gtsmodel.Poll, cols ...string) error
 
-	// DeletePollByID deletes the Poll with given ID from the database.
+	// DeletePollByID deletes the Poll with given ID from the
+	// database, along with all its associated poll votes.
 	DeletePollByID(ctx context.Context, id string) error
 
 	// GetPollVoteByID gets the PollVote with given ID from the database.
@@ -57,9 +58,6 @@ type Poll interface {
 	// PutPollVote puts the given PollVote in the database.
 	PutPollVote(ctx context.Context, vote *gtsmodel.PollVote) error
 
-	// DeletePollVotes deletes all PollVotes in Poll with given ID from the database.
-	DeletePollVotes(ctx context.Context, pollID string) error
-
 	// DeletePollVoteBy deletes the PollVote in Poll with ID, by account ID, from the database.
 	DeletePollVoteBy(ctx context.Context, pollID string, accountID string) error
 
-- 
cgit v1.2.3